Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki: Add annotation support #17762

Closed
torkelo opened this issue Jun 25, 2019 · 7 comments · Fixed by #18949
Closed

Loki: Add annotation support #17762

torkelo opened this issue Jun 25, 2019 · 7 comments · Fixed by #18949

Comments

@torkelo
Copy link
Member

torkelo commented Jun 25, 2019

No description provided.

@ryantxu
Copy link
Member

ryantxu commented Jun 25, 2019

I am hoping we can replace the special annotation query with any query that returns:

{
time
text
endTime?
tags?
userInfo?...
}

Details still need worked out :)

@lorenwest
Copy link
Contributor

Upvoting as we would prefer storing immutable system generated events/annotations in Loki than the mutable Grafana Annotations API

@aocenas aocenas self-assigned this Sep 6, 2019
@aocenas
Copy link
Member

aocenas commented Sep 6, 2019

Taking a stab at this. @davkal does it make sense to use label values as tags automatically for the annotations?

@aocenas
Copy link
Member

aocenas commented Sep 6, 2019

@ryantxu

I am hoping we can replace the special annotation query ...

Would make sense imho, but I think right now with all the other changes going on with datasource API I will do this the old way and we can change it later on.

@davkal
Copy link
Contributor

davkal commented Sep 6, 2019

Yeah, i'm happy with label values being the tags in the annotation.

@ryantxu
Copy link
Member

ryantxu commented Sep 6, 2019

If we are fine replacing the work soon (hopefully 6.5) than I am +1 for trying

@lorenwest
Copy link
Contributor

Thank you all for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants