Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Find more plugins on Grafana.com" should open in new tab #24622

Closed
yurividal opened this issue May 13, 2020 · 3 comments · Fixed by #24635 or #26305
Closed

"Find more plugins on Grafana.com" should open in new tab #24622

yurividal opened this issue May 13, 2020 · 3 comments · Fixed by #24635 or #26305
Labels
area/plugins

Comments

@yurividal
Copy link

What would you like to be added:
"Find more plugins on Grafana.com" button in "Plugins" section should open in a new tab, since it goes to a separate domain, outside of the user's domain.

Why is this needed:
It can get quite confusing when you click a button and you are taken outside of the site you are in, and taken into a totally different site, in a different domain (grafana internet site).
torkelo added a commit that referenced this issue May 13, 2020
@torkelo
PluginsListPage: More plugins button should open in new window
70b0b6a 
Fixes #24622
@torkelo torkelo mentioned this issue May 13, 2020
Merged
@torkelo
Copy link
Member

torkelo commented May 13, 2020

thanks for reporting this, opened PR #24635

torkelo added a commit that referenced this issue May 26, 2020
@torkelo
PluginsListPage: More plugins button should open in new window (#24635)
ac38dd8 
* PluginsListPage: More plugins button should open in new window

Fixes #24622

* Updated snapshot
aknuds1 pushed a commit that referenced this issue Jun 30, 2020
@torkelo @aknuds1
PluginsListPage: More plugins button should open in new window (#24635)
976a954 
* PluginsListPage: More plugins button should open in new window

Fixes #24622

* Updated snapshot
@yurividal
Copy link
Author

Has this been rejected? Its still not present in 7.1-beta3

@zoltanbedi
Copy link
Member

Ohh, so the fix is released but it did not actually fix the problem. Let me fix that real quick.

@zoltanbedi zoltanbedi reopened this Jul 13, 2020
zoltanbedi added a commit that referenced this issue Jul 13, 2020
@zoltanbedi
PluginsListPage: More plugins button should open in new window
2e00675 
Fixes #24622
@zoltanbedi zoltanbedi mentioned this issue Jul 13, 2020
Merged
zoltanbedi added a commit that referenced this issue Jul 14, 2020
@zoltanbedi
PluginsListPage: More plugins button should open in new window (#26305)
7bbfb57 
Fixes #24622
dprokop pushed a commit that referenced this issue Jul 16, 2020
@zoltanbedi @dprokop
PluginsListPage: More plugins button should open in new window (#26305)
a27f1be 
Fixes #24622

(cherry picked from commit 7bbfb57)
dprokop pushed a commit that referenced this issue Jul 16, 2020
@zoltanbedi @dprokop
PluginsListPage: More plugins button should open in new window (#26305)
05a0019 
Fixes #24622

(cherry picked from commit 7bbfb57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugins
Projects
None yet
Milestone
No milestone
3 participants
@torkelo @yurividal @zoltanbedi