Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataLinks: Default to url escaped variable interpolation format #26861

Closed
torkelo opened this issue Aug 7, 2020 · 1 comment · Fixed by #46100
Closed

DataLinks: Default to url escaped variable interpolation format #26861

torkelo opened this issue Aug 7, 2020 · 1 comment · Fixed by #46100

Comments

@torkelo
Copy link
Member

torkelo commented Aug 7, 2020

When Datalinks contain variables and they are interpolated they are not by default uri escaped.

the templateSrv replace function takes a default interpolation format as third argument so if we passed percentencode

here: https://github.com/grafana/grafana/blob/master/public/app/features/panel/panellinks/link_srv.ts#L325

and here: https://github.com/grafana/grafana/blob/master/packages/grafana-data/src/field/fieldOverrides.ts#L429

It should solve the problem

@torkelo torkelo added this to the 7.2 milestone Aug 7, 2020
@torkelo torkelo changed the title DataLinks: Default to url escaped values DataLinks: Default to url escaped variable interpolation format Aug 7, 2020
@dprokop dprokop removed this from the 7.2 milestone Sep 8, 2020
@meberli
Copy link

meberli commented Oct 21, 2021

had same issue with '++' in variable beeing replaced by %20 instead of %2B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants