Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore search UX: undo history missing entries #28656

Closed
Diggsey opened this issue Oct 29, 2020 · 2 comments · Fixed by #39114
Closed

Explore search UX: undo history missing entries #28656

Diggsey opened this issue Oct 29, 2020 · 2 comments · Fixed by #39114
Labels
area/explore datasource/Loki datasource/Prometheus prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/bug

Comments

@Diggsey
Copy link

Diggsey commented Oct 29, 2020

grafana_issue3

What happened:
Hitting undo skipped over a previous query ({namespace="pgl", app="loki"}).

What you expected to happen:
Running a query should force it to become a separate entry in the undo history: undo should never go back more than one query at a time, or else the user may lose queries.

How to reproduce it (as minimally and precisely as possible):
See GIF.

Environment:

  • Grafana version: 7.2.0
  • Data source type & version: Loki
  • User OS & Browser: Windows 10, Firefox
  • Grafana plugins: None
@hugohaggmark hugohaggmark added area/explore needs investigation for unconfirmed bugs. use type/bug for confirmed bugs, even if they "need" more investigating labels Oct 29, 2020
@ivanahuckova ivanahuckova added this to To do in Editor via automation Nov 10, 2020
@ivanahuckova
Copy link
Member

@Diggsey I was able to reproduce this. I have added this issue to the Editor project and we will probably look at it soon.

@ivanahuckova ivanahuckova added type/bug and removed needs investigation for unconfirmed bugs. use type/bug for confirmed bugs, even if they "need" more investigating labels Nov 10, 2020
@zoltanbedi zoltanbedi added the prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 21, 2021
glintik added a commit to glintik/grafana that referenced this issue Sep 12, 2021
@glintik
Fix issue with undo history in query field when suggestion inserted (g…
df09260 
…rafana#28656)
@glintik glintik mentioned this issue Sep 12, 2021
Merged
@glintik
Copy link
Contributor

glintik commented Sep 12, 2021 •
edited

Hi @ivanahuckova,

Please take a look at my fix in pull request.

Before inserting suggestion text in query field editor will store previous text in undo history.
I guess this also fixes #28653.

@gabor gabor removed this from To do in Editor Feb 10, 2022
ivanahuckova pushed a commit that referenced this issue Feb 11, 2022
@glintik
Fix issue with undo history in query field when suggestion inserted (#…
4d0a37b 
…28656) (#39114)
grafanabot pushed a commit that referenced this issue Feb 11, 2022
@glintik @grafanabot
Fix issue with undo history in query field when suggestion inserted (#…
8141c4f 
…28656) (#39114)

(cherry picked from commit 4d0a37b)
ivanahuckova pushed a commit that referenced this issue Feb 11, 2022
@grafanabot @glintik
Fix issue with undo history in query field when suggestion inserted (#…
a5637bd 
…28656) (#39114) (#45272)

(cherry picked from commit 4d0a37b)

Co-authored-by: Alexander Kubyshkin <i.am.glint@gmail.com>
alexweav pushed a commit that referenced this issue Mar 3, 2022
@glintik @alexweav
Fix issue with undo history in query field when suggestion inserted (#…
5c23eea 
…28656) (#39114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/explore datasource/Loki datasource/Prometheus prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

QueryField: Fix issue with undo history when suggestion is inserted (#28656) glintik/grafana
5 participants
@Diggsey @hugohaggmark @glintik @zoltanbedi @ivanahuckova