Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Introduce HTTP 207 Multi Status response to api/ds/query #48550

Merged
merged 17 commits into from
May 3, 2022
Merged

Plugins: Introduce HTTP 207 Multi Status response to api/ds/query #48550

merged 17 commits into from
May 3, 2022

Conversation

wbrowne
Copy link
Member

@wbrowne wbrowne commented Apr 29, 2022 •
edited
Loading

What this PR does / why we need it:
Based on this discussion

Which issue(s) this PR fixes:

Fixes #45870

Special notes for your reviewer:

@wbrowne wbrowne added this to the 9.0.0 milestone Apr 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022 •
edited
Loading

Code coverage report for PR #48550

Go TypeScript
main 57.8% 70.46%
PR 57.8% 70.47%
difference 0% .01%

@wbrowne wbrowne marked this pull request as ready for review May 3, 2022 13:34
@wbrowne wbrowne requested review from a team as code owners May 3, 2022 13:34
@wbrowne wbrowne requested review from jdbaldry and chri2547 and removed request for a team May 3, 2022 14:10
@grafanabot grafanabot added the type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project label May 3, 2022
@wbrowne wbrowne removed the breaking change Relevant for changelog generation label May 3, 2022
chri2547
chri2547 requested changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. Thank you!

wbrowne and others added 4 commits May 3, 2022 15:56
marefr
marefr approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wbrowne wbrowne added backport v8.5.x Mark PR for automatic backport to v8.5.x and removed no-backport Skip backport of PR labels May 3, 2022
@wbrowne wbrowne requested a review from chri2547 May 3, 2022 15:45
chri2547
chri2547 approved these changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wbrowne wbrowne merged commit 4ecd57f into main May 3, 2022
@wbrowne wbrowne deleted the ds-query-207 branch May 3, 2022 16:02
@grafanabot
Copy link
Contributor

The backport to v8.5.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-48550-to-v8.5.x origin/v8.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 4ecd57f49c75d72927be62aba23a15dca02f8eb6
# Push it to GitHub
git push --set-upstream origin backport-48550-to-v8.5.x
git switch main
# Remove the local backport branch
git branch -D backport-48550-to-v8.5.x

Then, create a pull request where the base branch is v8.5.x and the compare/head branch is backport-48550-to-v8.5.x.

@wbrowne wbrowne mentioned this pull request May 3, 2022
Merged
@marefr marefr modified the milestones: 9.0.0, 8.5.3 May 4, 2022
This was referenced Jun 17, 2022
Closed
Closed
@tolzhabayev tolzhabayev mentioned this pull request Apr 3, 2023
Closed
@marefr marefr mentioned this pull request May 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshhunt joshhunt joshhunt left review comments

@marefr marefr marefr approved these changes

@chri2547 chri2547 chri2547 approved these changes

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

@vickyyyyyyy vickyyyyyyy Awaiting requested review from vickyyyyyyy vickyyyyyyy is a code owner automatically assigned from grafana/aws-datasources

@JoaoSilvaGrafana JoaoSilvaGrafana Awaiting requested review from JoaoSilvaGrafana JoaoSilvaGrafana was automatically assigned from grafana/grafana-frontend-platform

@leventebalogh leventebalogh Awaiting requested review from leventebalogh leventebalogh was automatically assigned from grafana/plugins-platform-frontend

@papagian papagian Awaiting requested review from papagian papagian was automatically assigned from grafana/backend-platform

@kylebrandt kylebrandt Awaiting requested review from kylebrandt kylebrandt was automatically assigned from grafana/backend-platform

@sh0rez sh0rez Awaiting requested review from sh0rez sh0rez was automatically assigned from grafana/backend-platform

@pkolyvas pkolyvas Awaiting requested review from pkolyvas

@jdbaldry jdbaldry Awaiting requested review from jdbaldry jdbaldry was automatically assigned from grafana/docs-squad

Assignees

@wbrowne wbrowne

@marefr marefr

Labels
add to changelog area/backend/api area/backend/plugins area/backend area/frontend area/plugins backport v8.5.x Mark PR for automatic backport to v8.5.x datasource/CloudWatch type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
8.5.4
Development

Successfully merging this pull request may close these issues.

Plugins: Improve response status codes and instrumentation of /api/ds/query
5 participants
@wbrowne @grafanabot @joshhunt @marefr @chri2547