Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana 9.0.0: autocomplete annotation tags #50928

Closed
garnachod opened this issue Jun 16, 2022 · 5 comments · Fixed by #51164
Closed

Grafana 9.0.0: autocomplete annotation tags #50928

garnachod opened this issue Jun 16, 2022 · 5 comments · Fixed by #51164
Assignees
Labels
area/annotations prio/high Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/bug

Comments

@garnachod
Copy link

What happened:
When I try to create a new annotation in a metric and type (autocomplete) for the proper tag, the interface launch an error.
Screenshot from 2022-06-16 10-47-46

What you expected to happen:
In version 8.5.2 the annotation tag is autocomplete

How to reproduce it (as minimally and precisely as possible):
In a dashboard annotated with tags, try to create a new annotation and when the tag is searched may raise the error, in my case always the error is raised

Anything else we need to know?:
Error raised in file https://github.com/grafana/grafana/blob/main/packages/grafana-ui/src/utils/tags.ts Line:70
Maybe one value undefined is passed to this function?

Environment:

  • Grafana version: OSS 9.0.0
  • Data source type & version: Prometheus 2.36.0
  • OS Grafana is installed on: Amazon Linux 2, binary .tar.gz
  • User OS & Browser: Chrome Linux
  • Grafana plugins: Default
  • Others: Grafana configuration database, postgres
@gelicia
Copy link
Contributor

gelicia commented Jun 16, 2022

@garnachod Can you share what the error is that is above your type error? I'm wondering if this is another symptom of #50841 where we weren't sending the right headers with prometheus

@gelicia gelicia added the needs more info Issue needs more information, like query results, dashboard or panel json, grafana version etc label Jun 16, 2022
@garnachod
Copy link
Author

@gelicia sorry I didn't added the message before. I thought the messages were not related Screenshot from 2022-06-16 10-45-34

@gelicia
Copy link
Contributor

gelicia commented Jun 16, 2022

@garnachod Ah that is helpful, but I have one more question. Can you go to your network tab in dev tools and see if any calls there are failing? I'm looking for calls to something like api/datasources failing?

@garnachod
Copy link
Author

@gelicia I can't see any request falling at this moment, the API returns correctly the tags.
Screenshot from 2022-06-16 15-51-43
The system only fail if I try to search one tag.
Screenshot from 2022-06-16 15-55-22

@gelicia gelicia added area/annotations and removed needs more info Issue needs more information, like query results, dashboard or panel json, grafana version etc labels Jun 16, 2022
@carlkidcrypto
Copy link

carlkidcrypto commented Jun 16, 2022

Hello there @gelicia , I just experienced this same issue ~5 minutes ago.
Environment:
Grafana version: OSS 9.0.0 - image

Data source type & version: PSQL 13.7
OS Grafana is installed on: image
User OS & Browser: Chrome Linux - image
Grafana plugins: Default, Grafana Image Render

Steps to reproduce:

  1. click on a panel and attempt to create an annotation
  2. Then search for a Tag under 'Add tags'
  3. Error shows up:
    image
    image

Also worth mentioning that under the developer tools in chrome I don't see any network errors.

@ashharrison90 ashharrison90 self-assigned this Jun 16, 2022
@ashharrison90 ashharrison90 added type/bug prio/high Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/annotations prio/high Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants