Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus: Remove old client #52738

Closed
4 tasks
aocenas opened this issue Jul 25, 2022 · 5 comments
Closed
4 tasks

Prometheus: Remove old client #52738

aocenas opened this issue Jul 25, 2022 · 5 comments

Comments

@aocenas
Copy link
Member

aocenas commented Jul 25, 2022

Recently a new client was added to the Prometheus plugin to simplify response processing and improve performance and memory consumption. We still did not remove the old client and before we can do that there are a few things:

  • Put the old client behind the feature flag and make new client default
  • Observe if there are any issues
  • Remove old client code totally
  • Remove comparison logic

#52738 (comment)

@evandandrea
Copy link

@itsmylife to sync up with Beto, Kyle this week. Kyle has started to look into it, but hasn't gotten exemplars working.

@gtk-grafana
Copy link
Contributor

@itsmylife Create epic please!

@itsmylife
Copy link
Contributor

This is a task for the epic #52926

@bohandley
Copy link
Contributor

As of the plan put forward today put forward by Kyle,

  • v9.2: New client flag is there, should be feature complete, we encourage people to use it
  • v9.3: New client is default, flag to use old. Old client deprecated, no changes
  • v9.4: Delete old client (Feb)

https://raintank-corp.slack.com/archives/C03FZ9T50R1/p1665073148493249

We are moving this out of Q3 and potentially Q1 of 2023

@bohandley
Copy link
Contributor

bohandley commented Oct 27, 2022

Closing this to reorganize into this issue: https://github.com/grafana/observability-metrics-squad/issues/53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants