Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore tests: Changing visualization style #54889

Open
1 task done
Tracked by #54771
ifrost opened this issue Sep 8, 2022 · 4 comments
Open
1 task done
Tracked by #54771

Explore tests: Changing visualization style #54889

ifrost opened this issue Sep 8, 2022 · 4 comments
Labels
area/explore onboarding prio/low It's a good idea, but not scheduled for any release type/tech

Comments

@ifrost
Copy link
Contributor

ifrost commented Sep 8, 2022 •
edited

Add coverage for changing graph style to https://github.com/grafana/grafana/blob/v9.3.2/public/app/features/explore/ExploreGraph.tsx

#54889 (comment)
@ifrost ifrost mentioned this issue Sep 8, 2022
Open
@ifrost ifrost added type/tech area/explore prio/low It's a good idea, but not scheduled for any release onboarding labels Sep 8, 2022
@gelicia gelicia added the needs investigation for unconfirmed bugs. use type/bug for confirmed bugs, even if they "need" more investigating label Dec 14, 2022
@gelicia
Copy link
Contributor

gelicia commented Dec 14, 2022

We will want to check this is still relevant after some refactoring in this area.

@ifrost ifrost removed the needs investigation for unconfirmed bugs. use type/bug for confirmed bugs, even if they "need" more investigating label Jan 12, 2023
@ifrost
Copy link
Contributor Author

ifrost commented Jan 12, 2023

After refactoring ExploreGraph it no longer uses Redux to change the graph style so we can now test it at the component level.

@ifrost ifrost removed their assignment Jan 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity in the last year. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue with no recent activity label Jan 14, 2024
@ifrost
Copy link
Contributor Author

ifrost commented Jan 16, 2024 •
edited

This issue has been automatically marked as stale because it has not had activity in the last year. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

I think it's worth keeping it in the backlog. It's a low priority, and can be used as an onboarding task.

@github-actions github-actions bot removed the stale Issue with no recent activity label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/explore onboarding prio/low It's a good idea, but not scheduled for any release type/tech
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ifrost @gelicia