[Bug] Templating - json parse fails when using another template variable in query

[vaibhavinbayarea]

Please include this information:

• What Grafana version are you using?
  Version 3.1.0 (commit: v3.1.0)
• What datasource are you using?
  Elasticsearch
• What OS are you running grafana on?
  Ubuntu 14.04
• What did you do?
  When building a template with query that uses another template variable, often times json parse fails because of escaping of special characters.

My query looks like:
{"find": "terms", "field": "storageInstances.lunInstances.name", "query":"storageInstances.name:$Storage_instances"}

Where for example, the $Storage_instances = "cent7-pbs-client-app__ST__storage-1"

According to chrome console, the query being json parsed is:

a = "{"find": "terms", "field": "storageInstances.lunInstances.name", "query":"storageInstances.name:cent7\-pbs\-client\-app__ST__storage\-1"}"

The stack trace shows:

boot.8ba215a1.js:formatted:41332 SyntaxError: Unexpected number in JSON at position 102
    at Object.parse (native)
    at Object.X [as fromJson] (http://127.0.0.1:3200/public/app/boot.8ba215a1.js:34:21196)
    at h.metricFindQuery (http://127.0.0.1:3200/public/app/boot.8ba215a1.js:13:25614)
    at updateOptionsFromMetricFindQuery (http://127.0.0.1:3200/public/app/boot.8ba215a1.js:10:29774)
    at b (http://127.0.0.1:3200/public/app/boot.8ba215a1.js:41:20151)
    at h (http://127.0.0.1:3200/public/app/boot.8ba215a1.js:36:18232)
    at http://127.0.0.1:3200/public/app/boot.8ba215a1.js:36:18404
    at n.$eval (http://127.0.0.1:3200/public/app/boot.8ba215a1.js:36:25921)
    at n.$digest (http://127.0.0.1:3200/public/app/boot.8ba215a1.js:36:24429)
    at n.$apply (http://127.0.0.1:3200/public/app/boot.8ba215a1.js:36:26204)

If I use json formatter on the above query, it complains of an invalid character when "-" is escaped.

• What was the expected result?
  I believe the template should handle escaping of template variables according to json standards.

[vaibhavinbayarea]

For completeness,

When I remove the $Storage_instance variable and hard-code a name, the lookup works with the following

a = "{"find": "terms", "field": "storageInstances.lunInstances.name", "query":"storageInstances.name:cent7-pbs-client-app__ST__storage-1"}"

[klyngbaek]

+1

[vaibhavinbayarea]

So this seems to be working fine with top of the tree. I guess it got fixed sometime recently. Confirmation would be nice.

./bin/grafana-server -v
Version 4.0.0-pre1 (commit: v3.1.0+113-g3f861dd)

[torkelo]

maybe it was fixed by this commit?
8bd6b95

[torkelo]

can try to cherry pick that to 3.1.x branch and have it included in next patch release

[torkelo]

this is now in 3.1.x branch, will be included in next patch.

[vaibhavinbayarea]

Sorry for the late reply.. I did try the patch it and it works! Thanks!