-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: UI changes required to support v3 and Auth in Kafka Contact Point #61123
Conversation
Given #60655, I am assuming that the earliest release this change can only go into is 9.4. Is that correct? |
Can someone help me add 9.4 as the milestone for this please? Doesn't look like I have the permissions to do so. |
pkg/services/ngalert/notifier/channels_config/available_channels.go
Outdated
Show resolved
Hide resolved
@MohammadGhazanfar, I updated Grafana to import changes from your PR grafana/alerting#28. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for contributing!
Tested:
|
What is this feature?
This PR adds the code required to automatically create UI elements to match changes made in this alerting PR: grafana/alerting#28
This adds UI elements to perform the following,
Why do we need this feature?
Who is this feature for?
Anyone using the Kafka REST Contact Point with Grafana.
Which issue(s) does this PR fix?
Fixes #41176
Screenshots
The user can supply a password right here.
Or, they can choose to give a file path,
The user can select the desired API version like this,
References
Corresponding change in grafana/alerting: grafana/alerting#28
Need help with