New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Extend panel menu with links from plugins #63089
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
area/plugins
area/frontend
area/plugins/app
App Plugins
no-backport
Skip backport of PR
labels
Feb 8, 2023
grafanabot
added
the
levitate breaking change
A label indicating a breaking change and assigned by Levitate.
label
Feb 9, 2023
mckn
removed
the
levitate breaking change
A label indicating a breaking change and assigned by Levitate.
label
Feb 13, 2023
This feature is not yet released as part of a Grafana version so it is okay for us to break the APIs. |
mckn
added
add to changelog
and removed
no-changelog
Skip including change in changelog/release notes
labels
Feb 13, 2023
grafanabot
added
the
levitate breaking change
A label indicating a breaking change and assigned by Levitate.
label
Feb 13, 2023
mckn
requested review from
ashharrison90,
mckn,
dprokop,
ivanortegaalba,
marefr,
andresmgot,
sakjur,
papagian,
yangkb09 and
academo
and removed request for
a team and
mckn
February 23, 2023 13:30
packages/grafana-runtime/src/services/pluginExtensions/extensions.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
…ons.test.ts Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
leventebalogh
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/backend
area/frontend
area/plugins/app
App Plugins
area/plugins
levitate breaking change
A label indicating a breaking change and assigned by Levitate.
no-backport
Skip backport of PR
type/docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds the functionality for app plugins to add additional menu items to the dashboard panel menu.
In PR #61663 we introduced the plugin extension registry and allowed links to be registered statically via plugin.json. Whilst working on this PR we've decided to remove this in favour of only allowing extension links to be registered via the AppPlugin APIs. We believe this will make it much easier for us and plugin developers to understand and maintain.
The example below show case how to extend the dashboard panel menu with a link:
preload: true
for your plugin. We are collecting the extensions during the preload process of a plugin.Why do we need this feature?
To improve the user experience by making the UI feel less fragmented into different apps rather than one unified experience.
Who is this feature for?
End users and plugin developers
Which issue(s) does this PR fix?:
Related Epic #61658
Special notes for your reviewer:
Todo:
configureLinkExtension
function.