-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Extend panel menu with commands from plugins #63802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror/validation handling.
…stering via AppPlugin APIs
… together in configuration function.
We are introducing breaking changes compared to |
leventebalogh
approved these changes
Mar 7, 2023
jackw
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Drone doesn't seem to mind but I'm not sure about the commit history. It appears there are commits here that are from #63089 🤔
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/backend
area/frontend
levitate breaking change
A label indicating a breaking change and assigned by Levitate.
no-backport
Skip backport of PR
type/docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds the functionality for app plugins to add command menu items to the dashboard panel menu.
In PR #63089 we extended that functionality by adding support to add command extensions in the dashboard panel menu.
The difference between links and commands is that links will generate a real href link that will navigate the user away from the current page when clicked. Commands on the other hand will keep the user on the current page but call a command handler function that is provided when registering the plugin.
We do want to refactor and try to make the code a bit simpler but will do that in follow up PRs since it won't affect the external APIs of this feature and we do want to start to dog food this internally.
The example below show case how to extend the dashboard panel menu with a command:
preload: true
for your plugin. We are collecting the extensions during the preload process of a plugin.Why do we need this feature?
To improve the user experience by making the UI feel less fragmented into different apps rather than one unified experience.
Who is this feature for?
End users and plugin developers
Which issue(s) does this PR fix?:
Related Epic #61658