TraceView: Reworked header #63105
Merged
TraceView: Reworked header #63105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joey-grafana
added
area/frontend
add to changelog
area/datasource/frontend
datasource/Tempo
no-backport
|
Backend code coverage report for PR #63105 |
|
Frontend code coverage report for PR #63105
|
joey-grafana
requested review from
ashharrison90,
JoaoSilvaGrafana and
academo
and removed request for
a team
joey-grafana
requested review from
idafurjes and
ying-jeanne
and removed request for
a team,
jackw,
idafurjes and
ying-jeanne
joey-grafana
commented
Feb 10, 2023
public/app/features/explore/TraceView/components/TracePageHeader/TracePageHeader.tsx
Outdated
Show resolved
Hide resolved
adrapereira
requested changes
Feb 23, 2023
public/app/features/explore/TraceView/components/TracePageHeader/TracePageHeader.tsx
Outdated
Show resolved
Hide resolved
public/app/features/explore/TraceView/components/TracePageHeader/TracePageHeader.tsx
Outdated
Show resolved
Hide resolved
public/app/features/explore/TraceView/components/TracePageHeader/TracePageHeader.tsx
Outdated
Show resolved
Hide resolved
aocenas
reviewed
Feb 23, 2023
public/app/features/explore/TraceView/components/TracePageHeader/TracePageHeader.tsx
Outdated
Show resolved
Hide resolved
public/app/features/explore/TraceView/components/model/trace-viewer.ts
Outdated
Show resolved
Hide resolved
public/app/features/explore/TraceView/components/TracePageHeader/TracePageHeader.tsx
Outdated
Show resolved
Hide resolved
public/app/features/explore/TraceView/components/TracePageHeader/TracePageHeader.tsx
Outdated
Show resolved
Hide resolved
aocenas
approved these changes
Feb 28, 2023
adrapereira
approved these changes
Feb 28, 2023
ryantxu
pushed a commit
that referenced
this pull request
Mar 2, 2023
* Reworked header * Remove toggle from merge * Update test * Update how span is retrived * Tests * Update tests * Move new trace page header into its own component * Remove tests already covered in TracePageHeader.test.tsx * Update findHeaderTags * Tooltip updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
To improve the clarity and usability of trace data, we propose creating a new header with clearer and more concise information.
The trace duration will be moved next to the trace "title" and all labels will be removed to create a cleaner look.
Additionally, we will include a group of badges in the header that display the HTTP properties of the main span, including the method, target/url, and status. These badges will use color coding to quickly convey the value of the method and status.
Part of #61373
Why do we need this feature?
Improves UX of the trace view and the overall work has been discussed/refined with several stakeholders.
Who is this feature for?
Trace view users.
Special notes for your reviewer:
The following feature flag should be enabled
newTraceViewBefore
After
