Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics: Update Help to mention active viewers #63384

Merged
merged 5 commits into from
Jun 1, 2023
Merged

Metrics: Update Help to mention active viewers #63384

merged 5 commits into from
Jun 1, 2023

Conversation

monteiro-renato
Copy link
Contributor

@monteiro-renato monteiro-renato commented Feb 16, 2023 •
edited by tonypowa
Loading

Update help wording from StatsTotalActiveViewers, so it mentions "active viewers"

@monteiro-renato monteiro-renato requested a review from a team as a code owner February 16, 2023 08:35
@monteiro-renato monteiro-renato requested review from sakjur, zserge and mildwonkey and removed request for a team February 16, 2023 08:35
@grafanabot grafanabot added area/backend pr/external This PR is from external contributor labels Feb 16, 2023
@grafanabot
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@grafanabot grafanabot added stale Issue with no recent activity and removed stale Issue with no recent activity labels Mar 19, 2023
@grafanabot
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@grafanabot grafanabot added stale Issue with no recent activity and removed stale Issue with no recent activity labels Apr 20, 2023
@grafanabot
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@grafanabot grafanabot added stale Issue with no recent activity and removed stale Issue with no recent activity labels May 21, 2023
@tonypowa
Copy link
Contributor

👋 @sakjur
Whenever possible, could you please review the pull request and provide feedback to the author?

Thank you

sakjur
sakjur approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@sakjur sakjur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this'll need a rebase on the latest main to merge, but LGTM

@sakjur sakjur added add to changelog no-backport Skip backport of PR labels May 29, 2023
@sakjur sakjur added this to the 10.1.x milestone May 31, 2023
@sakjur sakjur merged commit 63c26e9 into grafana:main Jun 1, 2023
@sakjur
Copy link
Contributor

sakjur commented Jun 1, 2023

@monteiro-renato Thank you for your contribution 🙏

ryantxu pushed a commit that referenced this pull request Jun 1, 2023
@monteiro-renato @ryantxu
Metrics: Update Help to mention active viewers (#63384)
d9481f5
@ricky-undeadcoders ricky-undeadcoders removed this from the 10.1.x milestone Aug 1, 2023
@ricky-undeadcoders ricky-undeadcoders added this to the 10.1.0 milestone Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakjur sakjur sakjur approved these changes

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

Assignees
No one assigned
Labels
add to changelog area/backend no-backport Skip backport of PR pr/external This PR is from external contributor
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@monteiro-renato @grafanabot @tonypowa @sakjur @ricky-undeadcoders