Elasticsearch 5.x support #6356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! this looks pretty great. Think it needs some new unit tests to cover the new scenarios. |
torkelo
added
pr/needs-unit-tests
|
Uuuuuh, there's none, actually, I missed it because I was looking at the Datasource: Elasticsearch label and found nothing, sorry. Also yours is way more complete as I see ! Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I fixed the queries and the search types which were deprecated since Elasticsearch 2.0.0 and removed with Elasticsearch 5.0.
If you need to play around, here's a test instance : https://metrics.dissidence.ovh/dashboard/db/concorde (Default user/pass). The elasticsearch instance isn't directly open, but you can access it through Kibana at https://kibana.dissidence.ovh/. It is being fed data from Metricbeat through Logstash.
Should fix #5740.
Have a good day !