Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana 9.3 and 9.4 "Copy" disabled for legend text #64084

Closed
Tracked by #68135 ...
reyjrar opened this issue Mar 2, 2023 · 12 comments · Fixed by #83319
Closed
Tracked by #68135 ...

Grafana 9.3 and 9.4 "Copy" disabled for legend text #64084

reyjrar opened this issue Mar 2, 2023 · 12 comments · Fixed by #83319
Labels
area/legend area/panel/timeseries The main time series Graph panel triage/needs-confirmation used for OSS triage rotation - reported issue needs to be reproduced type/bug

Comments

@reyjrar
Copy link
Contributor

reyjrar commented Mar 2, 2023

What happened:

In earlier versions of Grafana, you could copy the text from the legend in the Legacy Graph and Time Series panels.

This appears to have gone away in 9.3 and 9.4 and is breaking some workflows.

What you expected to happen:

Highlight text in the legend, copy, and then paste into either the dashboard as a filter or else where for analysis.

How to reproduce it (as minimally and precisely as possible):

Attempt to highlight text in legend on the Time Series or Legacy Graph panels.

Anything else we need to know?:

If you want to do a solid, add a "copy to pasteboard" shortcut option to legend labels. It's often critical to workflows to take data from the legends to use as a filter or jumping off point for an investigation.

There may be some "UX Guideline" somewhere that suggests removing the highlight here is better, but without a "copy to pasteboard" option, it completely breaks all of our workflows.

We have "overview" dashboards that display a number of graphs bubbling "top N"s up to view. We typically pivot by trying to click on those and add them as filters. This has never been an option with Time Series or Legacy Graphs (but is in the Table View). It would be really useful to have that as well.

Environment:

  • Grafana version: 9.3.1 and 9.4.3
  • Data source type & version: Any
  • OS Grafana is installed on: CentOS 7
  • User OS & Browser: MacOS Firefox
  • Grafana plugins: N/A
  • Others: N/A
@mellieA
Copy link
Contributor

mellieA commented Mar 4, 2023

@reyjrar I tried this with grafana 9.4.3 and the timeseries panel using the chrome browser and I was able to click to select and then right-click to copy the text in the legend.

Is that the same workflow you're trying in firefox? A screen recording would be really helpful to see what you're experiencing

@tonypowa tonypowa added needs more info Issue needs more information, like query results, dashboard or panel json, grafana version etc area/panel/timeseries The main time series Graph panel labels Mar 6, 2023
@reyjrar
Copy link
Contributor Author

reyjrar commented Mar 7, 2023

I can work out a screen recording, but the reason I filed this ticket is I received reports from multiple users in my organization that they can no longer copy text in graph legends. I asked about ~15 people to try on various browsers and operating systems, and no one on any browser or operating system is able to even highlight text in a graph legend.

@reyjrar
Copy link
Contributor Author

reyjrar commented Mar 7, 2023

OH!

I did forget to mention, this happens with graphs where the Legend is set to "Table" display. You can highlight/copy from graphs with regular legends.

@reyjrar
Copy link
Contributor Author

reyjrar commented Mar 7, 2023

Attached is a screen recording showing the issue. You'll notice you can highlight and select text in text view, but once you set Legend to Table display, you can no longer select text inside the table.

grafana-no-highlight.mov

@reyjrar
Copy link
Contributor Author

reyjrar commented Mar 15, 2023

@mellieA Any chance you were able to verify this? It's really interrupting our workflows and I'm in a position where I might have to start downloading older releases until I find out where it was working.

@reyjrar
Copy link
Contributor Author

reyjrar commented Apr 11, 2023

PInging Again @mellieA and @tonypowa

@tonypowa tonypowa added triage/needs-confirmation used for OSS triage rotation - reported issue needs to be reproduced and removed needs more info Issue needs more information, like query results, dashboard or panel json, grafana version etc labels Apr 13, 2023
@mellieA
Copy link
Contributor

mellieA commented Apr 18, 2023

@reyjrar it works for me on 9.4.3 and 9.4.7 with Chrome. I was able to reproduce this with firefox and 9.4.7 and @tonypowa saw it on 9.4.3 with firefox too

@zurikus
Copy link

zurikus commented Apr 20, 2023

Does not work for us either, Grafana 9.4.7. with Chrome.
Unable to copy from table style "Legend" on Time Series graph.
It's only possible if we are entering in graph "Edit" mode.

@clickfreak
Copy link

problem still there, Grafana 10.1

But nuance: problem exists if legend shows as "table", if you set legend to "list" then you can select items as text, but its unusable in case if you need any sorting in legend (by min/max/last/total). tbh, i have a lot of dashboards and none of them use "list" in legend. Context: operations of thousands physical servers, terabits of traffic.

It will be good to remove Grafana version mention in title, its really confusing, especially managers in Grafana Labs ("why we need to take this task with problems in old versions? users just need to update grafana version" 😂)
Maybe add "since 9.3". Or create a new dedicated issue about problem in table legend.

// its really annoyed "bug", i start to compare Grafana with Nero Burning ROM (it was program to burn CD/DVD, but they start to implement a lot of strange things and finally forget about burning CD/DVD 😂). Why? Because another interesting thing is using canvas to show legend in another Grafana components ("State timeline", for example) which even doesn't allow search by text on the page using basic browser feature.

@Cougar
Copy link

Cougar commented Oct 16, 2023

I got hint here: https://github.com/grafana/grafana/pull/56690/files#r993297256
Fix is described here https://stackoverflow.com/a/56039655
I tried it directly in developer tools and adding user-select: text to my .css-7q41tt-LegendLabel style fixed this issue. Just have to find out now from where is this style coming.

@TimSimmons
Copy link

this still pains me on a daily basis 😭

@baldm0mma
Copy link
Contributor

baldm0mma commented Feb 26, 2024

This should be fixed by the above PR. And as a note, our current procedural framework does not accommodate back porting any change that isn't a critical bug-fix, so please consider upgrading to G11 when it releases. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/legend area/panel/timeseries The main time series Graph panel triage/needs-confirmation used for OSS triage rotation - reported issue needs to be reproduced type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants