Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legend: Allow item copy in Table mode #83319

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Legend: Allow item copy in Table mode #83319

merged 4 commits into from
Feb 27, 2024

Conversation

adela-almasan
Copy link
Contributor

@adela-almasan adela-almasan commented Feb 23, 2024 •
edited by leeoniya
Loading

Small fix to allow copying the legend item text in table mode.

legend_copy.mov

Fixes https://github.com/grafana/support-escalations/issues/9482
Fixes #64084

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@adela-almasan adela-almasan added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes area/legend labels Feb 23, 2024
@adela-almasan adela-almasan added this to the 11.0.x milestone Feb 23, 2024
@adela-almasan adela-almasan self-assigned this Feb 23, 2024
@adela-almasan adela-almasan requested a review from a team as a code owner February 23, 2024 15:28
@adela-almasan adela-almasan requested review from leeoniya and baldm0mma and removed request for a team February 23, 2024 15:28
@adela-almasan adela-almasan enabled auto-merge (squash) February 23, 2024 16:49
@baldm0mma baldm0mma mentioned this pull request Feb 26, 2024
Closed
@adela-almasan adela-almasan merged commit 9927144 into main Feb 27, 2024
18 checks passed
@adela-almasan adela-almasan deleted the legend_select branch February 27, 2024 00:35
chalapat pushed a commit to nokia/grafana that referenced this pull request Feb 27, 2024
@adela-almasan @chalapat
Legend: Allow item copy in Table mode (grafana#83319)
05b4674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarrs nmarrs nmarrs approved these changes

@baldm0mma baldm0mma baldm0mma approved these changes

@leeoniya leeoniya Awaiting requested review from leeoniya leeoniya is a code owner automatically assigned from grafana/dataviz-squad

@lwandz13 lwandz13 Awaiting requested review from lwandz13

Assignees

@adela-almasan adela-almasan

Labels
area/frontend area/legend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

Grafana 9.3 and 9.4 "Copy" disabled for legend text
4 participants
@adela-almasan @nmarrs @baldm0mma @fabrizio-grafana