Alerting: Remove and revert flag alertingBigTransactions #65976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobsonMT
added
area/alerting
JacobsonMT
requested review from
tskarhed,
yaelleC,
leventebalogh,
sakjur,
papagian and
zserge
and removed request for
a team
|
(Open the links below in a new tab to go to the correct steps)
|
grafanabot
added
the
levitate breaking change
|
You have successfully added a new CodeQL configuration |
armandgrillet
removed
the
levitate breaking change
grafanabot
added
type/docs
levitate breaking change
This is a partial revert of #56575 and a removal of the `alertingBigTransactions` flag. Real-word use has seen no clear performance incentive to maintain this flag. Lowered db connection count came at the cost of significant increase in CPU usage and query latency.
armandgrillet
force-pushed
the
jacobsonmt/revert_FlagAlertingBigTransactions
branch
from
1bdd0f9
to
36fbc35
Compare
armandgrillet
approved these changes
Apr 6, 2023
grobinson-grafana
added
backport v9.5.x
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Alerting: Remove and revert flag alertingBigTransactions This is a partial revert of #56575 and a removal of the `alertingBigTransactions` flag. Real-word use has seen no clear performance incentive to maintain this flag. Lowered db connection count came at the cost of significant increase in CPU usage and query latency. * Fix lint backend * Removed last bits of alertingBigTransactions --------- Co-authored-by: Armand Grillet <2117580+armandgrillet@users.noreply.github.com> (cherry picked from commit 63187fa)
grobinson-grafana
added
no-backport
santihernandezc
added
backport v9.5.x
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-65976-to-v9.5.x origin/v9.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 63187fae0ccb925ac603acf66da84d4695be3480
# When the conflicts are resolved, stage and commit the changes
git add . && git cherry-pick --continue
# If you have the GitHub CLI installed: Push the branch to GitHub and a PR:
gh pr view 65976 --json body --template 'Backport 63187fae0ccb925ac603acf66da84d4695be3480 from #65976{{ "\n\n---\n\n" }}{{ index . "body" }}' > .pr-body.txt
gh pr create --title "[v9.5.x] Alerting: Remove and revert flag alertingBigTransactions" --body-file .pr-body.txt --label "type/docs" --label "area/alerting" --label "area/backend" --label "area/frontend" --label "add to changelog" --label "type/debt" --label "no-backport" --label "levitate breaking change" --label "type/feature-toggle-removal" --label "backport" --base v9.5.x --milestone 9.5.x --web
# If you don't have the GitHub CLI installed: Push the branch to GitHub and manually create a PR:
git push --set-upstream origin backport-65976-to-v9.5.x
# Remove the local backport branch
git switch main
git branch -D backport-65976-to-v9.5.xUnless you've used the GitHub CLI above, now create a pull request where the |
grafana-delivery-bot
bot
added
the
backport-failed
santihernandezc
pushed a commit
that referenced
this pull request
Jun 29, 2023
* Alerting: Remove and revert flag alertingBigTransactions This is a partial revert of #56575 and a removal of the `alertingBigTransactions` flag. Real-word use has seen no clear performance incentive to maintain this flag. Lowered db connection count came at the cost of significant increase in CPU usage and query latency. * Fix lint backend * Removed last bits of alertingBigTransactions --------- Co-authored-by: Armand Grillet <2117580+armandgrillet@users.noreply.github.com> (cherry picked from commit 63187fa)
santihernandezc
added a commit
that referenced
this pull request
Jun 29, 2023
…0910) Alerting: Remove and revert flag alertingBigTransactions (#65976) * Alerting: Remove and revert flag alertingBigTransactions This is a partial revert of #56575 and a removal of the `alertingBigTransactions` flag. Real-word use has seen no clear performance incentive to maintain this flag. Lowered db connection count came at the cost of significant increase in CPU usage and query latency. * Fix lint backend * Removed last bits of alertingBigTransactions --------- Co-authored-by: Armand Grillet <2117580+armandgrillet@users.noreply.github.com> (cherry picked from commit 63187fa) Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of #55350 and a removal of the
alertingBigTransactionsflag.Real-word use has seen no clear performance incentive to maintain this flag. Lowered db connection count came at the cost of significant increase in CPU usage and query latency.