Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9.5.x] Alerting: Remove and revert flag alertingBigTransactions #70910

Merged
merged 1 commit into from Jun 29, 2023

Conversation

santihernandezc
Copy link
Contributor

Backport 63187fa from #65976


This is a partial revert of #55350 and a removal of the alertingBigTransactions flag.

Real-word use has seen no clear performance incentive to maintain this flag. Lowered db connection count came at the cost of significant increase in CPU usage and query latency.

* Alerting: Remove and revert flag alertingBigTransactions

This is a partial revert of #56575 and a removal of the `alertingBigTransactions` flag.

Real-word use has seen no clear performance incentive to maintain this flag. Lowered db connection count
came at the cost of significant increase in CPU usage and query latency.

* Fix lint backend

* Removed last bits of alertingBigTransactions

---------

Co-authored-by: Armand Grillet <2117580+armandgrillet@users.noreply.github.com>
(cherry picked from commit 63187fa)
@santihernandezc santihernandezc added type/docs area/alerting Grafana Alerting area/backend area/frontend add to changelog type/debt technical debt backport A backport PR no-backport Skip backport of PR levitate breaking change A label indicating a breaking change and assigned by Levitate. type/feature-toggle-removal labels Jun 29, 2023
@santihernandezc santihernandezc added this to the 9.5.x milestone Jun 29, 2023
@santihernandezc santihernandezc requested review from a team and chri2547 as code owners June 29, 2023 15:30
@santihernandezc santihernandezc requested review from joshhunt, L-M-K-B, mckn, zserge, mildwonkey and suntala and removed request for a team June 29, 2023 15:30
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@JacobsonMT JacobsonMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santihernandezc santihernandezc merged commit fd80720 into v9.5.x Jun 29, 2023
22 checks passed
@santihernandezc santihernandezc deleted the backport-65976-to-v9.5.x-pt2 branch June 29, 2023 18:18
@zerok zerok modified the milestones: 9.5.x, 9.5.6 Jun 30, 2023
@zerok zerok modified the milestones: 9.5.6, 9.5.x, 9.5.7 Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/alerting Grafana Alerting area/backend area/frontend backport A backport PR levitate breaking change A label indicating a breaking change and assigned by Levitate. no-backport Skip backport of PR type/debt technical debt type/docs type/feature-toggle-removal
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants