Elasticsearch: Fix processing of duplicated metric types and field #66973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
added
type/bug
datasource/Elasticsearch
add to changelog
no-backport
|
Backend code coverage report for PR #66973
|
|
Frontend code coverage report for PR #66973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are fixing naming of metric in case when we have duplicated metric type and duplicated field. In backend, we've had a logic that was handling duplicated query type with different field name, but it didn't account case when we also have same field.
To fix this, in case we have duplicated metric type and field, we append metric id to it. If metric is not duplicated, nothing changes.
Fixes #66849
Part of #54011
To test this, create query with duplicated metric type and field and test if response is correctly processed.