-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolkit: Remove deprecated package:build
, node-version-check
and toolkit:build
commands
#67475
Merged
academo
merged 9 commits into
main
from
academo/remove-package-build-node-version-check
Apr 28, 2023
Merged
Toolkit: Remove deprecated package:build
, node-version-check
and toolkit:build
commands
#67475
academo
merged 9 commits into
main
from
academo/remove-package-build-node-version-check
Apr 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-build-node-version-check
jackw
reviewed
Apr 28, 2023
@@ -112,5 +110,8 @@ | |||
"tslib": "2.4.0", | |||
"typescript": "4.8.2", | |||
"webpack": "^5.76.0" | |||
}, | |||
"devDependencies": { | |||
"@types/lodash": "4.14.191" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in devDependencies and dependencies? 🤔
jackw
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
ryantxu
pushed a commit
that referenced
this pull request
May 3, 2023
…`toolkit:build` commands (#67475)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/frontend
area/grafana/toolkit
area/plugins
breaking change
Relevant for changelog generation
no-backport
Skip backport of PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Removes deprecated commands from grafana toolkit.
Why do we need this feature?
We are removing unused functionalities from toolkit that are not longer used anywhere in grafana CI and were not yet removed.
Which issue(s) does this PR fix?:
related to: #55997
closes: #57660
closes: #57752
Usage: "Fixes #", or "Fixes (paste link of issue)"
-->
Fixes #
Special notes for your reviewer:
Please check that:
Release notice breaking change
The deprecated
package:build
,node-version-check
andtoolkit:build
commands in the Grafana Toolkit have been removed in this release.