Toolkit: Remove deprecated package:build, node-version-check and toolkit:build commands
#67475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-build-node-version-check
academo
added
area/plugins
add to changelog
area/grafana/toolkit
breaking change
academo
requested review from
kaydelaney and
jackw
and removed request for
a team
jackw
reviewed
Apr 28, 2023
| @@ -112,5 +110,8 @@ | |||
| "tslib": "2.4.0", | |||
| "typescript": "4.8.2", | |||
| "webpack": "^5.76.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@types/lodash": "4.14.191" | |||
There was a problem hiding this comment.
This is in devDependencies and dependencies? 🤔
ryantxu
pushed a commit
that referenced
this pull request
May 3, 2023
…`toolkit:build` commands (#67475)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Removes deprecated commands from grafana toolkit.
Why do we need this feature?
We are removing unused functionalities from toolkit that are not longer used anywhere in grafana CI and were not yet removed.
Which issue(s) does this PR fix?:
related to: #55997
closes: #57660
closes: #57752
Usage: "Fixes #", or "Fixes (paste link of issue)"
-->
Fixes #
Special notes for your reviewer:
Please check that:
Release notice breaking change
The deprecated
package:build,node-version-checkandtoolkit:buildcommands in the Grafana Toolkit have been removed in this release.