Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudWatch: Wrap VariableEditor dimension fields #68967

Merged
merged 1 commit into from May 25, 2023
Merged

CloudWatch: Wrap VariableEditor dimension fields #68967

merged 1 commit into from May 25, 2023

Conversation

iSatVeerSingh
Copy link
Contributor

What is this feature?

This PR fixes the UI bug in Cloudwatch Variable Editor. This fixes the wrap issue of Dimensions.

Why do we need this feature?

When too many dimension fields are added for a Dimension Values query, they extend out of the form.

Who is this feature for?

Any user or Admin of an organization who uses Cloudwatch datasource in Dashboard

Which issue(s) does this PR fix?:

Fixes #49652

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@iSatVeerSingh iSatVeerSingh requested a review from a team as a code owner May 24, 2023 10:54
@iSatVeerSingh iSatVeerSingh requested review from sarahzinger and idastambuk and removed request for a team May 24, 2023 10:54
@grafanabot grafanabot added datasource/CloudWatch area/frontend pr/external This PR is from external contributor labels May 24, 2023
kevinwcyu
kevinwcyu approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@kevinwcyu kevinwcyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, dimension fields are wrapping now

@kevinwcyu kevinwcyu changed the title CloudWatch: VariableEditor dimension fields CloudWatch: Wrap VariableEditor dimension fields May 24, 2023
@kevinwcyu kevinwcyu added this to the 10.1.x milestone May 24, 2023
@kevinwcyu kevinwcyu merged commit c045fcb into grafana:main May 25, 2023
24 checks passed
@idastambuk idastambuk mentioned this pull request Jun 9, 2023
Merged
3 tasks
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinwcyu kevinwcyu kevinwcyu approved these changes

@sarahzinger sarahzinger Awaiting requested review from sarahzinger sarahzinger is a code owner automatically assigned from grafana/aws-datasources

@idastambuk idastambuk Awaiting requested review from idastambuk idastambuk is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
add to changelog area/frontend datasource/CloudWatch no-backport Skip backport of PR pr/external This PR is from external contributor
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

CloudWatch: VariableEditor dimension fields should wrap
4 participants
@iSatVeerSingh @kevinwcyu @ricky-undeadcoders @grafanabot