Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch: Wrap filters and tag inputs in Variable Editor #69862

Merged
merged 1 commit into from Jun 16, 2023

Conversation

idastambuk
Copy link
Contributor

What is this feature?

Originally reported in #49652. Dimension fields were fixed in A follow up of #68967 and as, but this adds the shrink prop to EC2 Instance Attribute filters and ResourceARN tag inputs as well.

After:
Screenshot 2023-06-09 at 5 57 57 PM Screenshot 2023-06-09 at 5 57 47 PM

Why do we need this feature?

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@idastambuk idastambuk added datasource/CloudWatch no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Jun 9, 2023
@idastambuk idastambuk added this to the 10.1.x milestone Jun 9, 2023
@idastambuk idastambuk requested a review from a team as a code owner June 9, 2023 16:11
@idastambuk idastambuk requested review from sarahzinger and kevinwcyu and removed request for a team June 9, 2023 16:11
@idastambuk idastambuk merged commit 2d4db2f into main Jun 16, 2023
19 checks passed
@idastambuk idastambuk deleted the cloudwatch/fix-variable-editor branch June 16, 2023 11:44
harisrozajac pushed a commit that referenced this pull request Jun 30, 2023
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend datasource/CloudWatch no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants