[v10.0.x]: Themes: Unify secondary button and ToolbarButton #69049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Themes: Unify secondary button and ToolbarButton * Update * Update light theme * fix test * fix toolbar button border * fix disabled outline button style * Use transparent color instead of dynamic computed color for hover bg for text/outline versions. this is what figma components do (cherry picked from commit d4df5e0)
torkelo
added
backport
torkelo
requested review from
joshhunt,
L-M-K-B and
leventebalogh
and removed request for
a team
zerok
pushed a commit
that referenced
this pull request
Jun 22, 2023
Themes: Unify secondary button and ToolbarButton (#68250) * Themes: Unify secondary button and ToolbarButton * Update * Update light theme * fix test * fix toolbar button border * fix disabled outline button style * Use transparent color instead of dynamic computed color for hover bg for text/outline versions. this is what figma components do (cherry picked from commit d4df5e0) (cherry picked from commit 7d7a799)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #68250