Config: Add configuration option to define custom user-facing general error message for certain error types #70023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rly use it in the different engines and clean up the unit tests
mmandrus
requested review from
a team,
sakjur,
papagian and
yangkb09
and removed request for
a team
|
Summer Wollin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
grafanabot
added
datasource/Postgres
datasource/MSSQL
mmandrus
requested review from
mdvictor and
sjd210
and removed request for
a team
summerwollin
force-pushed
the
override-user-facing-error
branch
from
de7b260
to
08d2978
Compare
…na into override-user-facing-error
suntala
reviewed
Jun 15, 2023
|
@suntala We are having some CLA issues because Summer's local git config was messed up during a few commits. She corrected it to get the CLA check to pass, but subsequent pushes by me seem to be breaking it again. Could you give an approval, given that we have both signed the CLA, and I will look for a repository admin to force the merge for us? |
chri2547
reviewed
Jun 15, 2023
chri2547
reviewed
Jun 15, 2023
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
suntala
approved these changes
Jun 16, 2023
Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>
…na into override-user-facing-error
LudoVio
pushed a commit
that referenced
this pull request
Jun 26, 2023
… error message for certain error types (#70023) --------- Co-authored-by: Summer Wollin <summer.wollin@grafana.com> Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com> Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Currently, for detailed errors that we want to hide from front-end users, we display error messages saying things like "please inspect the server logs". This doesn't make sense for production deployments of Grafana where end users cannot check the logs themselves.
This feature adds a new config setting to customize this error message, and applies it throughout the backend where we found it was needed
Why do we need this feature?
Quality of life improvement for end users
Who is this feature for?
Users hosting production deployments of Grafana
Which issue(s) does this PR fix?:
Part one of #49441
Special notes
Corresponding Enterprise PR: https://github.com/grafana/grafana-enterprise/pull/5281
If there are any spots we missed, we will add them in follow-up PRs. Found each location by searching for the terms "inspect" and "server log"