-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Add configuration option to define custom user-facing general error message for certain error types #70023
Conversation
…rly use it in the different engines and clean up the unit tests
Summer Wollin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
de7b260
to
08d2978
Compare
…na into override-user-facing-error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small comments. I'm happy to approve this once the pipeline is green.
@suntala We are having some CLA issues because Summer's local git config was messed up during a few commits. She corrected it to get the CLA check to pass, but subsequent pushes by me seem to be breaking it again. Could you give an approval, given that we have both signed the CLA, and I will look for a repository admin to force the merge for us? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a suggestion. Thank you.
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>
…na into override-user-facing-error
… error message for certain error types (#70023) --------- Co-authored-by: Summer Wollin <summer.wollin@grafana.com> Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com> Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>
What is this feature?
Currently, for detailed errors that we want to hide from front-end users, we display error messages saying things like "please inspect the server logs". This doesn't make sense for production deployments of Grafana where end users cannot check the logs themselves.
This feature adds a new config setting to customize this error message, and applies it throughout the backend where we found it was needed
Why do we need this feature?
Quality of life improvement for end users
Who is this feature for?
Users hosting production deployments of Grafana
Which issue(s) does this PR fix?:
Part one of #49441
Special notes
Corresponding Enterprise PR: https://github.com/grafana/grafana-enterprise/pull/5281
If there are any spots we missed, we will add them in follow-up PRs. Found each location by searching for the terms "inspect" and "server log"