Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.0.x] Command palette: Include help links #70322

Merged
merged 1 commit into from Jun 19, 2023
Merged

[v10.0.x] Command palette: Include help links #70322

merged 1 commit into from Jun 19, 2023

Conversation

grafanabot
Copy link
Contributor

Backport db44ba3 from #70234

What is this feature?

  • enriches the help node with the frontend links so they correctly appear in the command palette
before after
image image

Why do we need this feature?

  • so help links appear properly in the command palette

Who is this feature for?

  • everyone!

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 @grafanabot
Command palette: Include help links (#70234)
063fd50 
enrich help node with frontend links

(cherry picked from commit db44ba3)
@grafanabot grafanabot requested a review from a team as a code owner June 19, 2023 12:30
@grafanabot grafanabot requested review from tskarhed and JoaoSilvaGrafana and removed request for a team June 19, 2023 12:30
@ashharrison90 ashharrison90 added this to the 10.0.x milestone Jun 19, 2023
ashharrison90
ashharrison90 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm bot 🤖

@ashharrison90 ashharrison90 enabled auto-merge (squash) June 19, 2023 12:31
@ashharrison90 ashharrison90 modified the milestone: 10.0.x Jun 19, 2023
@ashharrison90 ashharrison90 merged commit 77b024b into v10.0.x Jun 19, 2023
16 checks passed
@ashharrison90 ashharrison90 deleted the backport-70234-to-v10.0.x branch June 19, 2023 12:48
@zerok zerok modified the milestones: 10.0.x, 10.0.1 Jun 20, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 22, 2023
Merged
@jdbaldry jdbaldry mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashharrison90 ashharrison90 ashharrison90 approved these changes

@tskarhed tskarhed Awaiting requested review from tskarhed tskarhed is a code owner automatically assigned from grafana/grafana-frontend-platform

@JoaoSilvaGrafana JoaoSilvaGrafana Awaiting requested review from JoaoSilvaGrafana JoaoSilvaGrafana is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees
No one assigned
Labels
add to changelog area/frontend area/navigation backport A backport PR type/bug
Projects
None yet
Milestone
10.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grafanabot @ashharrison90 @zerok