Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command palette: Include help links #70234

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Command palette: Include help links #70234

merged 1 commit into from
Jun 19, 2023

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

  • enriches the help node with the frontend links so they correctly appear in the command palette
before after
image image

Why do we need this feature?

  • so help links appear properly in the command palette

Who is this feature for?

  • everyone!

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 ashharrison90 added this to the 10.0.x milestone Jun 16, 2023
@ashharrison90 ashharrison90 requested a review from a team as a code owner June 16, 2023 11:16
@ashharrison90 ashharrison90 self-assigned this Jun 16, 2023
@ashharrison90 ashharrison90 requested review from joshhunt and tskarhed and removed request for a team June 16, 2023 11:16
ivanortegaalba
ivanortegaalba approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@ivanortegaalba ivanortegaalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! This solves the possibility to use docs or keyboard shortcuts! Great addition! Thanks @ashharrison90! 💯

@ashharrison90 ashharrison90 merged commit db44ba3 into main Jun 19, 2023
20 checks passed
@ashharrison90 ashharrison90 deleted the ash/command-palette-help branch June 19, 2023 12:29
@grafanabot grafanabot mentioned this pull request Jun 19, 2023
Merged
3 tasks
grafanabot pushed a commit that referenced this pull request Jun 19, 2023
@ashharrison90 @grafanabot
Command palette: Include help links (#70234)
063fd50 
enrich help node with frontend links

(cherry picked from commit db44ba3)
ashharrison90 added a commit that referenced this pull request Jun 19, 2023
@grafanabot @ashharrison90
[v10.0.x] Command palette: Include help links (#70322)
77b024b 
Command palette: Include help links (#70234)

enrich help node with frontend links

(cherry picked from commit db44ba3)

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
@zerok zerok modified the milestones: 10.0.x, 10.0.1, 10.1.x Jun 20, 2023
LudoVio pushed a commit that referenced this pull request Jun 26, 2023
@ashharrison90 @LudoVio
Command palette: Include help links (#70234)
be617d8 
enrich help node with frontend links
harisrozajac pushed a commit that referenced this pull request Jun 30, 2023
@ashharrison90 @harisrozajac
Command palette: Include help links (#70234)
83df88e 
enrich help node with frontend links
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanortegaalba ivanortegaalba ivanortegaalba approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@tskarhed tskarhed Awaiting requested review from tskarhed tskarhed is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees

@ashharrison90 ashharrison90

Labels
add to changelog area/frontend area/navigation backport v10.0.x type/bug
Projects
Grafana Frontend Platform
Archived in project
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ashharrison90 @ivanortegaalba @zerok @ricky-undeadcoders @grafanabot