Alerting: Adds in-app documentation for Classic Conditions #70540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds in-app documentation that explains using Classic Conditions disables multi-dimensional alerts for the rule.
grobinson-grafana
added
area/alerting
gillesdemey
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
LGTM, @soniaAguilarPeiron I've made the updates to #70395 to be in sync.
gillesdemey
added a commit
that referenced
this pull request
Jun 22, 2023
grobinson-grafana
deleted the
grobinson/add-in-app-documentation-for-classics
branch
LudoVio
pushed a commit
that referenced
this pull request
Jun 26, 2023
This commit adds in-app documentation that explains using Classic Conditions disables multi-dimensional alerts for the rule.
soniaAguilarPeiron
added a commit
that referenced
this pull request
Jun 27, 2023
* Show description for each expression type in the body and change widht depending on the type * Move condition indicator to the header * Make order of fields in expressions to be consistent for each expression type * Add tooltip for expression type menu * Update styles depending on the expression type * Update styles and move add query button under queries * Add NeedHelpInfo component * Adress PR review comments * Apply description updates from #70540 * Rename gelTypes to expressionTypes * Update layout for expressions according to the real usecases * Update footer to include series count in all expressions --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
harisrozajac
pushed a commit
that referenced
this pull request
Jun 29, 2023
* Show description for each expression type in the body and change widht depending on the type * Move condition indicator to the header * Make order of fields in expressions to be consistent for each expression type * Add tooltip for expression type menu * Update styles depending on the expression type * Update styles and move add query button under queries * Add NeedHelpInfo component * Adress PR review comments * Apply description updates from #70540 * Rename gelTypes to expressionTypes * Update layout for expressions according to the real usecases * Update footer to include series count in all expressions --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This commit adds in-app documentation that explains using Classic Conditions disables multi-dimensional alerts for the rule.
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: