Dashboard: Add suggestion box for Flame Graph #70763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aocenas
reviewed
Jun 28, 2023
fabrizio-grafana
requested review from
joshhunt,
L-M-K-B,
axelavargas and
polibb
and removed request for
a team
aocenas
approved these changes
Jun 30, 2023
Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com>
fabrizio-grafana
changed the title
polibb
pushed a commit
that referenced
this pull request
Jul 14, 2023
Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this PR fix?:
Follow-up to a comment from issue 66428 - suggestion not shown for Flame Graph.
A proper suggestion is now shown for data that conform to the format expected by a Flame Graph.
Special notes for your reviewer:
Please check that: