New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus: Add disableRecordingRules datasource config #70903
Prometheus: Add disableRecordingRules datasource config #70903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@lwandz13 Why are we back porting this feature? I think we typically only backport bugs |
If this is v10 feature only it needs to be backported to v10 due tot he way the grafana/grafana repo is set up https://grafana.com/docs/writers-toolkit/writing-guide/tooling-and-workflows/backporting/ |
@lwandz13 that flow chart says no-backport D1=>D2=>T1. See https://raintank-corp.slack.com/archives/C02GTT9D6CW/p1688052585513679 for more info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, and things are working for me locally. Thanks for taking a look at this!
Docs is a little different than code in that we support two previous versions of grafana in addition to |
@Eve832 while this issue has a docs label, it is a new feature, not just docs updates |
Looks like we're hitting an API limit in drone, it resets every hour, I'll rerun the jobs in a bit and get this merged |
* Add config to toggle recording rules for Prometheus * Add documentation for Prometheus disableRecordingRules
* Add config to toggle recording rules for Prometheus * Add documentation for Prometheus disableRecordingRules
What is this feature?
This PR introduces a config to the Prometheus data source that optionally disables recording rules. It is by default set to
false
so that existing users of the plugin resort to the default behaviour as before.Why do we need this feature?
The Prometheus recording rules can be expensive for some instances. This PR adds an optional configuration disableRecordingRules to the Prometheus data source.
Who is this feature for?
Users of prometheus data source plugin
Which issue(s) does this PR fix?:
Fixes #69586
Special notes for your reviewer:
I need some help in making the documentation a bit more specific and useful. I think the snippets that I added to the documentation may be somewhat vague.
Please check that: