New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: US Government Azure AD OAuth URL not supported #71252

Closed

douglasryanadams opened this issue Jul 7, 2023 · 2 comments · Fixed by #71254

Milestone

Contributor

douglasryanadams commented Jul 7, 2023

What went wrong?

What happened:

Using https://login.microsoftonline.us URLs for auth_url results in a 500 with error log "unable to extract tenant ID from URL"

What did you expect to happen:

Using https://login.microsoftonline.us URLs for auth_url allows OAuth to proceed as expected

How do we reproduce it?

Step 1:

Open Grafana and select Azure AD SSO login option

Step 2:

Provide Azure AD SSO credentials to your AD service

Step 3:

Error message appears

What Grafana version are you using?

10.0.1

Optional Questions:

Is the bug inside a Dashboard Panel?

Copy the panel's "get-help" data here

Grafana Platform?

None

User's OS?

No response

User's Browser?

No response

Is this a Regression?

None

Are Datasources involved?

No response

Anything else to add?

I am working on a PR to fix the regex statement that's causing this error. The code's updated and tested but I'm making sure I go through the process correctly (which is why I created this issue).

douglasryanadams changed the title ~~Azure AD OAuth: US Government Azure URL not supported~~ Auth: US Government Azure AD OAuth URL not supported

douglasryanadams pushed a commit to douglasryanadams/grafana that referenced this issue


          Auth: Fix US gov azure ad oauth URL parsing

4f6f392

Updates regex for tenant ID parsing to support .us domains in addition
to .com domains for Azure AD.

Fixes grafana#71252

douglasryanadams mentioned this issue

Auth: Fix US gov azure ad oauth URL parsing #71254

Merged

3 tasks

douglasryanadams added a commit to douglasryanadams/grafana that referenced this issue


          Auth: Fix US gov azure ad oauth URL parsing

527733e

Updates regex for tenant ID parsing to support .us domains in addition
to .com domains for Azure AD.

Fixes grafana#71252

douglasryanadams added a commit to douglasryanadams/grafana that referenced this issue


          Auth: Fix US gov azure ad oauth URL parsing

a9dd414

Updates regex for tenant ID parsing to support .us domains in addition
to .com domains for Azure AD.

Fixes grafana#71252

Jguer added this to the 10.1.x milestone

Contributor

Jguer commented Jul 10, 2023

Hi @douglasryanadams , thanks for reporting this issue and for contributing the fix. We'll try and confirm the difference in domain doesn't affect other functionality

Jguer closed this as completed in #71254

Jguer pushed a commit that referenced this issue


          Auth: Fix US gov azure ad oauth URL parsing (#71254)

3a245e4

Updates regex for tenant ID parsing to support .us domains in addition
to .com domains for Azure AD.

Fixes #71252

polibb pushed a commit that referenced this issue


          Auth: Fix US gov azure ad oauth URL parsing (#71254)

70ddfba

Updates regex for tenant ID parsing to support .us domains in addition
to .com domains for Azure AD.

Fixes #71252

danfinn mentioned this issue

Upgrading to from 9.x to 10.x breaks Azure AD authentication in Azure Gov Cloud #71973

Closed

danfinn commented Jul 19, 2023

When can this fix be expected in your dockerhub repo?

ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment