Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Slack alert graph using files.upload #7175

Closed
gerrickw opened this issue Jan 7, 2017 · 4 comments · Fixed by #9392
Closed

[Feature request] Slack alert graph using files.upload #7175

gerrickw opened this issue Jan 7, 2017 · 4 comments · Fixed by #9392
Labels
area/alerting/notifications Issues when sending alert notifications type/feature-request
Milestone

Comments

@gerrickw
Copy link

gerrickw commented Jan 7, 2017

  • What Grafana version are you using?
    v4.1.0-beta1
  • What datasource are you using?
    influxdb, graphite, opentsdb
  • What OS are you running grafana on?
    ubuntu 16.04 and 14.04

Would it be possible to support file uploading to slack instead of s3 or webdav? Looking at hubot it appears they added support near the end of June based on slackapi/hubot-slack#62. Previously files.upload api was not allowed from bots, but looks like policy allows bots to upload. https://api.slack.com/methods/files.upload

Within our company policy we can not upload to a public repo, although a slack image push would be allowed.

Finding the alerting setup interesting, thanks for the great work.

@torkelo torkelo added area/alerting/notifications Issues when sending alert notifications type/feature-request labels Jan 7, 2017
@bergquist
Copy link
Contributor

This makes sense.

We implemented the slack notifier before the summer and I guess we missed the fact that they added support for file upload.

This should be implemented the same way as emails. If public_image_store is configure it should be used, otherwise it should fall back to slack file upload.

Should also make it configurable in notifications settings since some people don't want to share their graphs to slack.

@bergquist bergquist added this to the 4.2.0 milestone Jan 9, 2017
@bergquist bergquist modified the milestones: 4.2.0-beta1, 4.2.0 Feb 14, 2017
@bergquist bergquist self-assigned this Feb 15, 2017
@bergquist bergquist modified the milestones: 4.3.0, 4.2.0-beta1 Feb 17, 2017
@bergquist bergquist removed their assignment Feb 17, 2017
@DanCech
Copy link
Collaborator

DanCech commented Mar 16, 2017

+1 this would be very helpful for hosted grafana

@kyle-c9000
Copy link

+1 agreed

@torkelo torkelo removed this from the 4.3.0 milestone Apr 11, 2017
@meganchinburg
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting/notifications Issues when sending alert notifications type/feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants