Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: Fix small drop target for importing dashboards #72170

Merged
merged 1 commit into from Jul 24, 2023

Conversation

kunxl-gg
Copy link
Contributor

@kunxl-gg kunxl-gg commented Jul 22, 2023

What is this feature?
This solves the issue of not being able to upload files outside the centre of the drop zone. As you can see the screenshot below we have solved the issue.

Screenshot 2023-07-22 at 9 40 02 PM

Which issue(s) does this PR fix?:
Fixes #71880

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@kunxl-gg kunxl-gg requested a review from a team as a code owner July 22, 2023 17:00
@kunxl-gg kunxl-gg requested review from joshhunt and eledobleefe and removed request for a team July 22, 2023 17:00
@CLAassistant
Copy link

CLAassistant commented Jul 22, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/frontend pr/external This PR is from external contributor labels Jul 22, 2023
@joshhunt
Copy link
Contributor

joshhunt commented Jul 22, 2023

Thanks for the contribution @kunxl-gg! Please make sure the email you've configured git with is linked to your github account (see Setting your commit email address) for more details, and sign the CLA 👍🏻

Note - we're cutting a new release next week so if you get this done before Wednesday it'll go into 10.1 :)

@joshhunt joshhunt added this to the 10.1.x milestone Jul 22, 2023
@joshhunt joshhunt added add to changelog no-backport Skip backport of PR labels Jul 22, 2023
@joshhunt joshhunt changed the title file gets uploaded even on the periphery side of the dropzone Dashboards: Fix small drop target for importing dashboards Jul 22, 2023
@kunxl-gg
Copy link
Contributor Author

kunxl-gg commented Jul 22, 2023

Thanks for the contribution @kunxl-gg! Please make sure the email you've configured git with is linked to your github account (see Setting your commit email address) for more details, and sign the CLA 👍🏻

Note - we're cutting a new release next week so if you get this done before Wednesday it'll go into 10.1 :)

I have signed the CLA and configured my email on git. What next. This is a new laptop, probably that is why I didn't have my email configured.

@joshhunt
Copy link
Contributor

Hmm @kunxl-gg, it looks like you'll need to re-commit with the new author details with the proper email address. The problem is with how the commit isn't linked to your user, which can be see by the commit missing your profile photo.

image

git commit --amend --reset-author --no-edit should do the trick. Note, this will rewrite the commit, so you'll need to git push --force that commit after.

Once the commit is attributed to your git user correctly, revisit the CLA link to trigger the check again. Then in in the week we will review + merge if all good 👍🏻

@kunxl-gg
Copy link
Contributor Author

Done. Sorry for taking your time. Will take care of these minor details next time.

Copy link
Contributor

@joshhunt joshhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in both Storybook and in Dashboard import and it works great! Thanks for the contribution @kunxl-gg.

This should go out in the Grafana 10.1 release in the coming weeks 🥳

@joshhunt joshhunt merged commit c2a6dcf into grafana:main Jul 24, 2023
12 checks passed
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend no-backport Skip backport of PR pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GrafanaUI: FileDropzone does not register full area as a drop target
4 participants