New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboards: Fix small drop target for importing dashboards #72170
Conversation
Thanks for the contribution @kunxl-gg! Please make sure the email you've configured git with is linked to your github account (see Setting your commit email address) for more details, and sign the CLA 👍🏻 Note - we're cutting a new release next week so if you get this done before Wednesday it'll go into 10.1 :) |
I have signed the CLA and configured my email on git. What next. This is a new laptop, probably that is why I didn't have my email configured. |
Hmm @kunxl-gg, it looks like you'll need to re-commit with the new author details with the proper email address. The problem is with how the commit isn't linked to your user, which can be see by the commit missing your profile photo.
Once the commit is attributed to your git user correctly, revisit the CLA link to trigger the check again. Then in in the week we will review + merge if all good 👍🏻 |
Done. Sorry for taking your time. Will take care of these minor details next time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this in both Storybook and in Dashboard import and it works great! Thanks for the contribution @kunxl-gg.
This should go out in the Grafana 10.1 release in the coming weeks 🥳
What is this feature?
This solves the issue of not being able to upload files outside the centre of the drop zone. As you can see the screenshot below we have solved the issue.
Which issue(s) does this PR fix?:
Fixes #71880
Special notes for your reviewer:
Please check that: