Transformations: Fix group by field transformation field name text-overflow #74173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarkilhed
changed the title
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
…erflow (grafana#74173) Transformations: Grow field name label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This fixes an issue where a very long field name would be hard to read due to text overflowing.
Before:
After:
In the event that there is a very long field name, the label will grow to accommodate the whole name. Optimally the other labels would grow to the same length as the longest field, but this would require a new solution to how we tackle forms. Since this problem should be an outlier, this solution seems good enough for now.
Fixes: https://github.com/grafana/support-escalations/issues/7266
Special notes for your reviewer:
Please check that: