-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Remove old panel code and leave only new panel design #74196
Conversation
Yes, we can do it in a separate PR :). |
…fana#74196) * delete PanelHeader * PanelHeaderMenuItem is only used in PageHeader * PanelHeaderCorner only used by PanelEditorTableView * PanelHeaderMenuTrigger not used anywhere * PanelHeaderMenuWrapperNew is PanelHeaderMenuWrapper, old one is deleted * remove newPanelChromeUI from test * delete feature flag newPanelChromeUI * PanelHeaderMenuWrapperNew is PanelHeaderMenuWrapper, old one is deleted
) * delete PanelHeader * PanelHeaderMenuItem is only used in PageHeader * PanelHeaderCorner only used by PanelEditorTableView * PanelHeaderMenuTrigger not used anywhere * PanelHeaderMenuWrapperNew is PanelHeaderMenuWrapper, old one is deleted * remove newPanelChromeUI from test * delete feature flag newPanelChromeUI * PanelHeaderMenuWrapperNew is PanelHeaderMenuWrapper, old one is deleted
What is this feature?
newPanelChromeUI
feature flag that we have already enabled by default.PanelHeader
,PanelHeaderLoadingIndicator
,PanelHeaderMenuTrigger
PanelHeaderMenuItem
is only used byPageHeader
, hence moved therePanelHeaderCorner
is only used byPanelEditorTableView
, hence moved there->PanelHeaderMenuWrapper
PanelHeaderMenuWrapperNew
,->PanelHeaderMenu
PanelHeaderMenuNew
Why do we need this feature?
Because we are not supporting the old panel setup and should have only the new one in place.
Who is this feature for?
Grafana users.
Which issue(s) does this PR fix?:
Fixes #70790
Special notes for your reviewer:
Please check that:
Release notice breaking change
Removed all components for the old panel header design.