Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Remove old panel code and leave only new panel design #74196

Merged
merged 20 commits into from
Sep 12, 2023

Conversation

polibb
Copy link
Contributor

@polibb polibb commented Aug 31, 2023

What is this feature?

  • Remove the newPanelChromeUI feature flag that we have already enabled by default.
  • Remove old code that the old panel header was using: PanelHeader, PanelHeaderLoadingIndicator, PanelHeaderMenuTrigger
  • Leave whichever components from the old panel are used elsewhere, but move them to the places they are used, instead of leaving them where it's not relevant for them anymore:
    PanelHeaderMenuItem is only used by PageHeader, hence moved there
    PanelHeaderCorner is only used by PanelEditorTableView, hence moved there
  • Removed components that had corresponding components with the word "New" in them, as the latter will be the only ones now: PanelHeaderMenuWrapper -> PanelHeaderMenuWrapperNew, PanelHeaderMenu -> PanelHeaderMenuNew

Why do we need this feature?

Because we are not supporting the old panel setup and should have only the new one in place.

Who is this feature for?

Grafana users.

Which issue(s) does this PR fix?:

Fixes #70790

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

Release notice breaking change

Removed all components for the old panel header design.

@polibb polibb added this to the 10.2.x milestone Aug 31, 2023
@polibb polibb self-assigned this Aug 31, 2023
@polibb polibb requested review from grafanabot and a team as code owners August 31, 2023 15:02
@polibb polibb requested review from leandro-deveikis, dafydd-t, dprokop, kaydelaney, tskarhed and eledobleefe and removed request for a team August 31, 2023 15:02
@github-actions github-actions bot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Aug 31, 2023
@github-actions github-actions bot removed the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Sep 11, 2023
@axelavargas
Copy link
Member

Thank you for checking it out, @axelavargas! I did notice that we haven't updated the PanelEditorTableView, but thought this was our plan for some reason - that the table has a life of its own 😄. Anyway, I will look into it to update it. Could we do it in a separate following PR? If yes, I'll add it to the leftover tasks: #70790. The breaking change is the removed FF, is that not how it usually goes with removing feature flags?

Yes, we can do it in a separate PR :).

@polibb polibb enabled auto-merge (squash) September 12, 2023 08:39
@polibb polibb merged commit b14263a into main Sep 12, 2023
19 checks passed
@polibb polibb deleted the polibb/remove-NewPanelChromeUI-ff branch September 12, 2023 08:54
chauchausoup pushed a commit to chauchausoup/grafana that referenced this pull request Sep 15, 2023
…fana#74196)

* delete PanelHeader

* PanelHeaderMenuItem is only used in PageHeader

* PanelHeaderCorner only used by PanelEditorTableView

* PanelHeaderMenuTrigger not used anywhere

* PanelHeaderMenuWrapperNew is PanelHeaderMenuWrapper, old one is deleted

* remove newPanelChromeUI from test

* delete feature flag newPanelChromeUI

* PanelHeaderMenuWrapperNew is PanelHeaderMenuWrapper, old one is deleted
rwwiv pushed a commit that referenced this pull request Oct 2, 2023
)

* delete PanelHeader

* PanelHeaderMenuItem is only used in PageHeader

* PanelHeaderCorner only used by PanelEditorTableView

* PanelHeaderMenuTrigger not used anywhere

* PanelHeaderMenuWrapperNew is PanelHeaderMenuWrapper, old one is deleted

* remove newPanelChromeUI from test

* delete feature flag newPanelChromeUI

* PanelHeaderMenuWrapperNew is PanelHeaderMenuWrapper, old one is deleted
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Dashboard: Remove newPanelChromeUI feature flag
3 participants