Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.2.x] Plugins: Keep working when there is no internet access #78092

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[v10.2.x] Plugins: Keep working when there is no internet access #78092

merged 1 commit into from
Nov 14, 2023

Conversation

leventebalogh
Copy link
Contributor

Backport ea12eec from #77978

Related issues: #77905, https://github.com/grafana/support-escalations/issues/8305

What is the problem?

The "Add new connection" and "Plugins catalog" pages are not loading in case there is no internet access.

Why?

Although releasing #75272 made it possible to load these pages seamlessly in case the connection to GCOM times out, it didn't cater for any other network errors properly when fetching GCOM.

Solution

This PR is fixing the issue by not blocking the main UI flow in case the remote plugins are not available.

Testing

Tested the following flows manually:

  • The "Plugins Catalog" and the "Add new connection" pages are still working if there is no internet
  • The "Plugins Catalog" and the "Add new connection" pages do not hang if the GCOM connection is slow or times out. In case the connection is slow, then the remotely available plugins will load later.
  • The "Plugins Catalog" and the "Add new connection" operate correctly when there is internet connection

@leventebalogh
Plugins: Keep working when there is no internet access (#77978)
0c7cdec 
* fix: make connections and plugins-catalog work when GCOM is not available

* fix: remove unused import

(cherry picked from commit ea12eec)
@leventebalogh leventebalogh added this to the 10.2.x milestone Nov 14, 2023
@leventebalogh leventebalogh requested a review from a team as a code owner November 14, 2023 08:07
@leventebalogh leventebalogh requested review from mckn and removed request for a team November 14, 2023 08:07
@leventebalogh leventebalogh enabled auto-merge (squash) November 14, 2023 08:18
@leventebalogh leventebalogh merged commit 11918a9 into v10.2.x Nov 14, 2023
25 checks passed
@leventebalogh leventebalogh deleted the backport-77978-to-v10.2.x branch November 14, 2023 08:18
@ifrost ifrost modified the milestones: 10.2.x, 10.2.2 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

@mckn mckn Awaiting requested review from mckn mckn is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees
No one assigned
Labels
add to changelog area/frontend area/plugins area/plugins-catalog backport A backport PR type/bug
Projects
None yet
Milestone
10.2.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leventebalogh @andresmgot @ifrost