Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data interval/resolution issue introduced in 8.5.10 using graphite datasource #78973

Open
rschitz opened this issue Dec 1, 2023 · 9 comments
Assignees
Labels
datasource/Graphite triage/needs-confirmation used for OSS triage rotation - reported issue needs to be reproduced

Comments

@rschitz
Copy link

rschitz commented Dec 1, 2023

What happened?

I know 8.5.27 is not technically supported anymore but we need time to migrate so we'd like to use it but we found an issue and were able to track down to version 8.5.10 meaning 8.5.9 was acting fine.

Here is the problem using the same dataset, in 8.5.9 the resolution match the storage schema but not 8.5.10 and above:

287287247-01b916c5-9dcf-4326-acb3-07892b4795b3

287296383-2fffb992-401c-452d-98c1-516662edb441

287102708-f38f8b40-7c2f-46c0-92ef-bee4faa69595

287103047-8697563e-9d15-4fe6-840d-da96a5541569

I'm not asking for a fix bug if this is code line i could change or a file i could replace to use the 8.5.27 and still be compliant with security it would be amazing.

ref : sexibytes/sexigraf#366

Thanks again for this awesome tool, we are using it in our monitoring appliance project SexiGraf for almost 10 years now :)

What did you expect to happen?

data resolution should match graphite storage schema

Did this work before?

before 8.5.10

How do we reproduce it?

upgrade to 8.5.10 or above

Is the bug inside a dashboard panel?

No response

Environment (with versions)?

No response

Grafana platform?

None

Datasource(s)?

Graphite 1.2

@tonypowa tonypowa added datasource/Graphite triage/needs-confirmation used for OSS triage rotation - reported issue needs to be reproduced labels Dec 27, 2023
@bohandley bohandley self-assigned this Jan 4, 2024
@bohandley
Copy link
Contributor

Hi @rschitz! Thank you for researching this and thank you for your support for Grafana!

You are correct as we are not supporting versions this far back, but I was able to isolate a single change in Graphite between v8.5.9 and v8.5.10. I was not able to reproduce the issue but I hope this helps!

#51623

@rschitz
Copy link
Author

rschitz commented Jan 4, 2024

Hi @bohandley thanks a lot for your time!
i think i already tried to revert those changes in the files but i'll try again and let you know.

@rschitz
Copy link
Author

rschitz commented Jan 4, 2024

Tried those files https://github.com/grafana/grafana/pull/51623/files but nothing append. Am I supposed to do something after the modifications other than a service restart? (tried a reboot)
Thanks for your support, i'll soon check if this also affect 9.x and 10.x

@rschitz
Copy link
Author

rschitz commented Jan 4, 2024

@bohandley would you like to have access to a 8.5.9 and a 8.5.27 with the same dataset?

@bohandley
Copy link
Contributor

Sure! I can't promise anything though. I looked at the changes from v8.5.9 to v8.5.27 and I wasn't able to find any meaningful changes in Graphite data source other than what I showed you. There have been no meaningful changes in the backend which is where I would expect the change would come from. For these reasons, I am not sure this is in the Graphite data source in grafana.

If you could share that access as well as any info on your Graphite configuration in Grafana. Nothing changed with that, correct? Are you using a specific version? MetricTank or default?

@rschitz
Copy link
Author

rschitz commented Jan 7, 2024

I'll send you access to both env on you email soon, thanks a lot for your time!
I'm using default install, i can also share the packet files used to deploy the vms.

@rschitz
Copy link
Author

rschitz commented Jan 15, 2024

@bohandley did you get my email?

@bohandley
Copy link
Contributor

bohandley commented Jan 16, 2024 via email

@rschitz
Copy link
Author

rschitz commented Jan 16, 2024

Great, thank you. Just wanted to be sure it didnt end up in a spam folder or something.
Again, Thanks a lot for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource/Graphite triage/needs-confirmation used for OSS triage rotation - reported issue needs to be reproduced
Projects
None yet
Development

No branches or pull requests

3 participants