Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.3.x] ShareModal: Fixes url sync issue that caused issue with save drawer #81721

Merged
merged 1 commit into from Feb 1, 2024
Merged

[v10.3.x] ShareModal: Fixes url sync issue that caused issue with save drawer #81721

merged 1 commit into from Feb 1, 2024

Conversation

ivanortegaalba
Copy link
Contributor

Backport 7c2622a from #81706

Fixes the issue where it would close any modal or drawer on unmount

Fixes #81009

@torkelo @ivanortegaalba
ShareModal: Fixes url sync issue that caused issue with save drawer (#…
12f8d6e 
…81706)

* ShareModal: Fixes url sync issue that caused issue with save drawer

* Updated fix

(cherry picked from commit 7c2622a)
@ivanortegaalba ivanortegaalba added this to the 10.3.x milestone Feb 1, 2024
@ivanortegaalba ivanortegaalba requested review from a team as code owners February 1, 2024 15:27
@ivanortegaalba ivanortegaalba requested review from lucychen-grafana, axelavargas and oscarkilhed and removed request for a team February 1, 2024 15:27
@ivanortegaalba ivanortegaalba merged commit be850d6 into v10.3.x Feb 1, 2024
22 checks passed
@ivanortegaalba ivanortegaalba deleted the backport-81706-to-v10.3.x branch February 1, 2024 15:45
@briangann briangann modified the milestones: 10.3.x, 10.3.3 Feb 2, 2024
@BrewTestBot BrewTestBot mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkelo torkelo torkelo approved these changes

@evictorero evictorero Awaiting requested review from evictorero

@lucychen-grafana lucychen-grafana Awaiting requested review from lucychen-grafana lucychen-grafana is a code owner automatically assigned from grafana/sharing-squad

@axelavargas axelavargas Awaiting requested review from axelavargas axelavargas is a code owner automatically assigned from grafana/dashboards-squad

@oscarkilhed oscarkilhed Awaiting requested review from oscarkilhed oscarkilhed is a code owner automatically assigned from grafana/dashboards-squad

Assignees
No one assigned
Labels
add to changelog area/frontend backport A backport PR type/bug
Projects
Sharing squad
Status: 🚀 Done
Milestone
10.3.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanortegaalba @torkelo @briangann