ShareModal: Fixes url sync issue that caused issue with save drawer #81706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
oscarkilhed,
ivanortegaalba,
juanicabanas and
ashharrison90
and removed request for
a team,
oscarkilhed and
ivanortegaalba
torkelo
added
backport v10.3.x
|
This PR must be merged before a backport PR will be created. |
evictorero
approved these changes
Feb 1, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-81706-to-v10.3.x origin/v10.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 7c2622a4f1e325d50984498d2b55fd6afabfee71When the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-81706-to-v10.3.x
# Create the PR body template
PR_BODY=$(gh pr view 81706 --json body --template 'Backport 7c2622a4f1e325d50984498d2b55fd6afabfee71 from #81706{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[v10.3.x] ShareModal: Fixes url sync issue that caused issue with save drawer" --body-file - --label "type/bug" --label "area/frontend" --label "add to changelog" --label "backport" --base v10.3.x --milestone 10.3.x --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-81706-to-v10.3.x
# Create a pull request where the `base` branch is `v10.3.x` and the `compare`/`head` branch is `backport-81706-to-v10.3.x`.
# Remove the local backport branch
git switch main
git branch -D backport-81706-to-v10.3.x |
grafana-delivery-bot
bot
added
the
backport-failed
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
…81706) * ShareModal: Fixes url sync issue that caused issue with save drawer * Updated fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where it would close any modal or drawer on unmount
Fixes #81009