Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

influxdb dashboard storage and international characters in title #827

Closed
huhongbo opened this issue Sep 19, 2014 · 3 comments
Closed

influxdb dashboard storage and international characters in title #827

huhongbo opened this issue Sep 19, 2014 · 3 comments

Comments

@huhongbo
Copy link

the influxdb dashboard save can only save english dashboard and load

when mix english with chinese only english name can be save
for example
I save the dashboard name "hello中国"
and the path will be /dashboard/db/hello
so It will cause the problem bcs the path is not uniq

@huhongbo
Copy link
Author

https://github.com/grafana/grafana/blob/master/src/app/services/influxdb/influxdbDatasource.js#L191
kbn.slugifyForUrl in es and influxdb code only left english word,so this is the problem
another problem is btoa(id)
if the id has non-latin ,the btoa will fail too
btoa(encodeURIComponent(id)) will work
but still some problem to see

@torkelo torkelo changed the title influxdb dashboard save bug influxdb dashboard storage and international characters in title Sep 19, 2014
@huhongbo
Copy link
Author

the elastic search save have the same problem

@jordanrinke
Copy link
Contributor

Hmm I did that btoa in the hopes it would accomodate a wider range of characters. This might be a good solution? http://ecmanaut.blogspot.ca/2006/07/encoding-decoding-utf8-in-javascript.html

@torkelo torkelo added this to the 2.0-RC1 milestone Apr 15, 2015
dsotirakis pushed a commit that referenced this issue Apr 26, 2023
* AuthJWT: Fix JWT query param leak (CVE-2023-1387) [9.2.x] (#827)

* fix JWT query param leak

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
Co-authored-by: Kalle Persson <kalle.persson@grafana.com>

* skip broken test

---------

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
Co-authored-by: Kalle Persson <kalle.persson@grafana.com>

* Update SAML lib

* Replace golang.org/x/net with v0.7.0

* Revert "Replace golang.org/x/net with v0.7.0"

This reverts commit 5df9a41749131aff2cedd26885429b99fdc4c3fd.

---------

Co-authored-by: Jo <joao.guerreiro@grafana.com>
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
Co-authored-by: Kalle Persson <kalle.persson@grafana.com>
Co-authored-by: Mihaly Gyongyosi <mgyongyosi@users.noreply.github.com>
dsotirakis pushed a commit that referenced this issue Apr 27, 2023
* AuthJWT: Fix JWT query param leak (CVE-2023-1387) [9.2.x] (#827)

* fix JWT query param leak

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
Co-authored-by: Kalle Persson <kalle.persson@grafana.com>

* skip broken test

---------

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
Co-authored-by: Kalle Persson <kalle.persson@grafana.com>

* Update SAML lib

* Replace golang.org/x/net with v0.7.0

* Revert "Replace golang.org/x/net with v0.7.0"

This reverts commit 5df9a41749131aff2cedd26885429b99fdc4c3fd.

---------

Co-authored-by: Jo <joao.guerreiro@grafana.com>
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
Co-authored-by: Kalle Persson <kalle.persson@grafana.com>
Co-authored-by: Mihaly Gyongyosi <mgyongyosi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants