[v10.4.x] Tempo: Better fallbacks for metrics query #83688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
* Use query as fallback when there's one series and no labels. Use "" as the fallback for empty label values. Stop using the `promLabels` value from the Tempo response * Set refId to remove mentions of promLabels * Add quotes around the string value, add space after comma separator * Use name as refId when possible (cherry picked from commit 036e190)
grafana-delivery-bot
bot
added
add to changelog
area/frontend
backport
adrapereira
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 036e190 from #83619
What is this feature?
This PR fixes a couple of bugs we were seeing when Tempo returned no labels or labels with empty values for a specific query when using the metrics endpoint.
When there are no labels and the results contains a single series, we fallback to the query string, to mimic the Prometheus datasource.
When the value for a label is an empty string we force the series name to be
""since this is the actual value of the label. In Tempo the values are typed so we know that""is the value of empty string instead of the absence of value.Why do we need this feature?
We were seeing errors and undesired behaviours when querying the metrics endpoint of Tempo.
Who is this feature for?
Users of the Tempo datasource.
Which issue(s) does this PR fix?:
Fixes grafana/tempo#3429
Special notes for your reviewer:
Please check that: