-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus: Use frontend package in Prometheus DS with a feature toggle #84397
Merged
bohandley
merged 11 commits into
main
from
bohandley/prometheus-frontend-package-feature-toggle
Mar 23, 2024
Merged
Prometheus: Use frontend package in Prometheus DS with a feature toggle #84397
bohandley
merged 11 commits into
main
from
bohandley/prometheus-frontend-package-feature-toggle
Mar 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmylife
reviewed
Mar 19, 2024
...ic/app/plugins/datasource/prometheus/configuration/DataSourceHttpSettingsOverhaulPackage.tsx
Show resolved
Hide resolved
7aa1640
to
e7e444d
Compare
itsmylife
approved these changes
Mar 22, 2024
e7e444d
to
eaa45a6
Compare
… with files from @grafana/prometheus
41a241a
to
455764d
Compare
itsmylife
reviewed
Mar 23, 2024
itsmylife
approved these changes
Mar 23, 2024
ashharrison90
pushed a commit
that referenced
this pull request
Mar 26, 2024
…le (#84397) * add feature toggle usePrometheusFrontendPackage * add feature toggle logic to Prometheus module * use config editor with package and remove configOverhaul feature toggle * update betterer because we will be removing other files as we replace with files from @grafana/prometheus * fix exemplar ds picker selector * add more description to ts-ignore * remove go.work.sum change * copy go.work.sum from main * update go.work.sum after talking with ismail * put back the promlib entry --------- Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
ashharrison90
pushed a commit
that referenced
this pull request
Mar 26, 2024
…le (#84397) * add feature toggle usePrometheusFrontendPackage * add feature toggle logic to Prometheus module * use config editor with package and remove configOverhaul feature toggle * update betterer because we will be removing other files as we replace with files from @grafana/prometheus * fix exemplar ds picker selector * add more description to ts-ignore * remove go.work.sum change * copy go.work.sum from main * update go.work.sum after talking with ismail * put back the promlib entry --------- Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This uses
@grafana/prometheus
frontend package in core Prometheus with the feature toggleusePrometheusFrontendPackage
.Components that directly use the package in
module.ts
:Component that indirectly uses the package:
@grafana/prometheus
package.*** also updating go.work.sum after talking with @itsmylife
Why do we need this?
This is part of the decoupling and decomposing work of Grafana Prometheus.
Special notes:
There will need to be a note in the change log when this work is GA. Notes to include
Please check that: