Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus: Use frontend package in Prometheus DS with a feature toggle #84397

Merged
merged 11 commits into from
Mar 23, 2024

Conversation

bohandley
Copy link
Contributor

@bohandley bohandley commented Mar 13, 2024

What is this?

This uses @grafana/prometheus frontend package in core Prometheus with the feature toggle usePrometheusFrontendPackage.

Components that directly use the package in module.ts:

  • DataSource
  • PromQueryEditorByApp
  • PromCheatSheet

Component that indirectly uses the package:

  • ConfigEditor: This component still requires auth from Azure and SigV4. These will be removed at a future date (to be determined with a migration plan to external Prometheus data sources). In the meantime, we use a Config Editor component that supports these auths and at a deeper level uses components from the @grafana/prometheus package.

*** also updating go.work.sum after talking with @itsmylife

Why do we need this?

This is part of the decoupling and decomposing work of Grafana Prometheus.

Special notes:

There will need to be a note in the change log when this work is GA. Notes to include

  • Automatic version detection is disabled
  • Default support of labels with match[] over series endpoint (users with old versions of Prometheus will have to update the version and type in the Configuration Page to get support for the series endpoint.

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@bohandley bohandley force-pushed the bohandley/prometheus-frontend-package-feature-toggle branch from 7aa1640 to e7e444d Compare March 20, 2024 19:16
@bohandley bohandley requested a review from a team as a code owner March 20, 2024 19:16
@bohandley bohandley force-pushed the bohandley/prometheus-frontend-package-feature-toggle branch from e7e444d to eaa45a6 Compare March 22, 2024 17:09
@bohandley bohandley requested a review from a team as a code owner March 22, 2024 17:09
@bohandley bohandley force-pushed the bohandley/prometheus-frontend-package-feature-toggle branch from 41a241a to 455764d Compare March 22, 2024 17:58
go.work.sum Show resolved Hide resolved
@itsmylife itsmylife self-requested a review March 23, 2024 00:24
@bohandley bohandley merged commit d084595 into main Mar 23, 2024
19 checks passed
@bohandley bohandley deleted the bohandley/prometheus-frontend-package-feature-toggle branch March 23, 2024 00:47
@ashharrison90 ashharrison90 modified the milestones: 11.0.x, 11.1.x Mar 25, 2024
ashharrison90 pushed a commit that referenced this pull request Mar 26, 2024
…le (#84397)

* add feature toggle usePrometheusFrontendPackage

* add feature toggle logic to Prometheus module

* use config editor with package and remove configOverhaul feature toggle

* update betterer because we will be removing other files as we replace with files from @grafana/prometheus

* fix exemplar ds picker selector

* add more description to ts-ignore

* remove go.work.sum change

* copy go.work.sum from main

* update go.work.sum after talking with ismail

* put back the promlib entry

---------

Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
ashharrison90 pushed a commit that referenced this pull request Mar 26, 2024
…le (#84397)

* add feature toggle usePrometheusFrontendPackage

* add feature toggle logic to Prometheus module

* use config editor with package and remove configOverhaul feature toggle

* update betterer because we will be removing other files as we replace with files from @grafana/prometheus

* fix exemplar ds picker selector

* add more description to ts-ignore

* remove go.work.sum change

* copy go.work.sum from main

* update go.work.sum after talking with ismail

* put back the promlib entry

---------

Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
@ashharrison90 ashharrison90 modified the milestones: 11.1.x, 11.0.x Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants