Prometheus: Use the frontend package in Prometheus and remove feature toggle #86080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohandley
added
datasource/Prometheus
no-backport
bohandley
requested review from
ivanortegaalba,
kaydelaney,
leeoniya,
baldm0mma,
gillesdemey and
tomratcliffe
and removed request for
a team
bohandley
force-pushed
the
bohandley/prometheus-frontend-package-use-GA
branch
from
1938030
to
a3625c9
Compare
bohandley
added a commit
that referenced
this pull request
Apr 15, 2024
* add native histogram functions to code editor * add native histogram function types for query builder * add functions to query builder * add test to show parsing breaks from code to builder * add histogram_avg to code editor * add histogram_avg to builder and make parity between package and core * add functions to hard coded promql file for highlighting * remove native histogram test so that it can be added in #85942 * remove functions from core prometheus js to prevent merge conflict in #86080 * use xit for test instead of removing it
bohandley
requested review from
joshhunt and
L-M-K-B
and removed request for
a team
xlson
added a commit
that referenced
this pull request
Apr 16, 2024
* main: (482 commits) I18N: Split loadTranslations i18next plugin into seperate file (#86217) Grafana UI: `StackingEditor` and `addHideFrom` - Replace `HorizontalGroup` with `Stack` (#86192) Dashboard: Migration - Add public dashboard tag in the nav bar (#86204) mssql: decouple sqleng (#86130) Docs: Fix typos (#85651) Playlists: Enable kubernetesPlaylists by default in OSS (#86259) DashboardScene: Fixes saving dashboard with angular panels (#86098) DashboardScene: Fix empty row repeat issue (#86095) Prometheus: Use the frontend package in Prometheus and remove feature toggle (#86080) docs: add annotations play link (#86206) Chore: add missing modowner (#86234) docs: add thresholds play link (#86212) docs: added logs panel play link; added dedup options, reformatted fig (#86209) docs: query data/relative time range override play link (#86213) Docs: added bar gauge play link (#86205) Docs: add template var Play link; cleanup existing (#86074) Prometheus: Add native histogram functions (#86002) K8s: add ID token to requests outbound to new query endpoint (#86214) Prometheus: Respect dashboard queries when querying ad hoc filter labels (#85674) Chore: Use `handleReducedMotion` to smooth the animation in `LoadingBar` (#85808) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This PR fully switches the core Grafana Prometheus frontend over to the
grafana/prometheusfrontend package. This PR accomplishes 4 things.Why do we need this?
The frontend package has been tested in ops by feature toggle rollout and in the AMP DS, an external Prometheus data source plugin.
The frontend package code is working. It is time to switch over to it so we do not have to duplicate our work in the frontend package and core Prometheus Typescript files.
Special notes for reviewer:
This work is dependent on this PR in Grafana Enterprise to fix an import that relies on old core Prometheus code. More specifically, the RawQuery component should be imported from grafana/experimental since the refactor of the shared code into that package (grafana/promtheus needs to use that package too and we will at a later date).
Please check that: