Canvas: Add direction options for connections #84620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew08t
added
add to changelog
area/panel/canvas
drew08t
requested review from
Develer and
adela-almasan
and removed request for
a team
public/app/plugins/panel/canvas/components/connections/ConnectionSVG.tsx
Outdated
Show resolved
Hide resolved
adela-almasan
approved these changes
Mar 18, 2024
baldm0mma
reviewed
Mar 18, 2024
public/app/plugins/panel/canvas/components/connections/ConnectionSVG.tsx
Outdated
Show resolved
Hide resolved
baldm0mma
approved these changes
Mar 18, 2024
|
LGTM, we can work on the labels for selector (or using icons), but this is not something blocking this PR. |
codeincarnate
approved these changes
Mar 19, 2024
| @@ -120,4 +121,22 @@ export const optionBuilder: OptionSuppliers = { | |||
| }, | |||
| }); | |||
| }, | |||
|
|
|||
| addDirection: (builder, context) => { | |||
| const category = ['Direction']; | |||
There was a problem hiding this comment.
May make sense to call this "Connection Direction" or something like that. It's a bit ambiguous at the moment.
There was a problem hiding this comment.
I think in this case, because it's in the context of a selected connection, I'll leave it as is for now to be consistent with its siblings.
There was a problem hiding this comment.
Or perhaps "Arrow Direction" would suffice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding direction option for canvas connections.
For single segment connection:
For multi-segment connection:
Closes #83268