Cloudwatch: add support for multi instances #10570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
osius
commented
Jan 19, 2018
osius
commented
- Add support for multi InstanceId on ebs_volume_ids(region, instanceids)
Codecov Report
@@ Coverage Diff @@
## master #10570 +/- ##
==========================================
+ Coverage 49.75% 49.82% +0.06%
==========================================
Files 320 320
Lines 22553 22573 +20
Branches 1180 1180
==========================================
+ Hits 11221 11246 +25
+ Misses 10685 10676 -9
- Partials 647 651 +4 |
|
looks pretty good, @bergquist what do you think? |
|
can you fix the conflicts caused by your other PR ? |
|
sure, thanks for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.