Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for InfluxDB's time zone clause #12245

Closed
wants to merge 1 commit into from
Closed

Add support for InfluxDB's time zone clause #12245

wants to merge 1 commit into from

Conversation

jkreileder
Copy link
Contributor

This fixes #10322 by adding support for Influx DB's time zone clause.

@jangaraj
Copy link
Contributor

I would like to have an option to use dashboard timezone. It will be useful, especially if dashboard uses browser time zone.

@jkreileder
Copy link
Contributor Author

Good idea but probably not in the scope of the issue and this pull request as it is a more global thing:
You can get the browser's timezone with Intl.DateTimeFormat().resolvedOptions().timeZone but this should be made available for all of Grafana and not just the influxdb plug-in.

(My use case is actually the other way round, I want Grafana panels to use the timezone of the data. This pull requests is one step required for that. The other is #558; I'll probably make a pull request for that sometime soon.)

@rmiggily
Copy link

Finally! A feature to resolve all the time zone related headaches of InfluxDB! Thanks for your commit. Could somebody please merge this change?

@cykl
Copy link
Contributor

cykl commented Sep 19, 2018

Any blocker? These 20 LOCs are super useful. How can I help to get them merged?

@blalor
Copy link

blalor commented Nov 5, 2018

Are there any blockers to getting this merged? I'd really like to have this feature!

@cby016
Copy link

cby016 commented Dec 10, 2018

+1 for this feature

@cykl
Copy link
Contributor

cykl commented Dec 12, 2018

@torkelo I apologize for the direct ping, but this PR has been stalled since this summer without any positive or negative feedback from Grafana team. How can we move forward?

I just tested this PR against v5.4.1 and InfluxDB 1.6.0. Works for me.

@torkelo
Copy link
Member

torkelo commented Dec 12, 2018

Sorry for lack of feedback. Think it needs some UX changes to it does not take up space in the query editor when not used (similar to some other option that can be added via the plus button after group by).

Also needs corresponding backend update (influxdb code in backend go code)

@torkelo
Copy link
Member

torkelo commented Dec 23, 2018

Another PR (that was a continuation on this PR, #14627) was now merged!

Thank you for contributing to Grafana!

@torkelo torkelo closed this Dec 23, 2018
@rmiggily
Copy link

@torkelo Thanks for your time.

@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Add support for InfluxDB tz clause
8 participants