Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanosecond timestamp support #14711

Merged
merged 10 commits into from Jan 28, 2019
Merged

Conversation

andxr
Copy link
Contributor

@andxr andxr commented Jan 2, 2019

Created a new macro for retrieving metrics with nanosecond timestamps using PostgreSQL. The name for the new macro is $__unixEpochFilterNano and it works in the same way as $__unixEpochFilter.

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2019

CLA assistant check
All committers have signed the CLA.

@svenklemm
Copy link
Contributor

this should probably be named unixEpochNanoFilter and unixEpochNanoFrom and unixEpochNanoTo should be added as new macros as well, probably makes sense to add this to the other sql datasources too

@andxr
Copy link
Contributor Author

andxr commented Jan 3, 2019

Thanks @svenklemm for your response. I have made those changes and I have added them to mysql and msqql.

Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andxr
Copy link
Contributor Author

andxr commented Jan 21, 2019

@torkelo You are right, documentation updated

@marefr marefr changed the title Nanosecond timestamp support postgresql Nanosecond timestamp support Jan 28, 2019
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marefr marefr merged commit fce3548 into grafana:master Jan 28, 2019
@marefr
Copy link
Member

marefr commented Jan 28, 2019

Thank you for contributing to Grafana!

@marefr marefr added this to the 6.0-beta1 milestone Jan 28, 2019
marefr added a commit that referenced this pull request Jan 28, 2019
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants