Fix: Wrap value of multi variable in array when coming from URL #16992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aocenas
commented
May 10, 2019
| expect(setValueMock).toHaveBeenCalledWith({ text: 'none', value: 'none' }); | ||
| }); | ||
|
|
||
| it('sets text and value even if it does not match any option and it is array', async () => { |
There was a problem hiding this comment.
@torkelo Sorry realised there was one more case that was kinda broken after you reviewed. This makes behaviour more consistent for custom values in URL as for single value it worked fine but for multiple custom values the text would be empty.
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 13, 2019
* grafana/master: chore: remove x character in explore Dashboard: show refresh button in kiosk mode (grafana#17032) Devenv: Updated gauge test dashboard Chore: reintroduce gosec (grafana#17021) Gauge: tweaks to background color and height usage (grafana#17019) Feature: provide multildap server configuration (grafana#16914) (feat/explore): Support for new LogQL filtering syntax (grafana#16674) fix(explore): Prevent double querying for Prometheus and Loki (grafana#17004) Chore: No implict any fixes (grafana#17020) move log package to /infra (grafana#17023) Chore: Lowered implicit anys limit to 5386 Chore: Updated snapshot Select: Fixed isOpen issue Chore: Typescript no-implicit any fixes progress (grafana#17018) GraphPanel: show results for all SeriesData (grafana#16966) Fix: Wrap value of multi variable in array when coming from URL (grafana#16992)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 13, 2019
* grafana/master: chore: remove x character in explore Dashboard: show refresh button in kiosk mode (grafana#17032) Devenv: Updated gauge test dashboard Chore: reintroduce gosec (grafana#17021) Gauge: tweaks to background color and height usage (grafana#17019) Feature: provide multildap server configuration (grafana#16914) (feat/explore): Support for new LogQL filtering syntax (grafana#16674) fix(explore): Prevent double querying for Prometheus and Loki (grafana#17004) Chore: No implict any fixes (grafana#17020) move log package to /infra (grafana#17023) Chore: Lowered implicit anys limit to 5386 Chore: Updated snapshot Select: Fixed isOpen issue Chore: Typescript no-implicit any fixes progress (grafana#17018) GraphPanel: show results for all SeriesData (grafana#16966) Fix: Wrap value of multi variable in array when coming from URL (grafana#16992)
ryantxu
added a commit
to NatelEnergy/grafana
that referenced
this pull request
May 14, 2019
* grafana/master: (30 commits) chore: remove x character in explore Dashboard: show refresh button in kiosk mode (grafana#17032) Devenv: Updated gauge test dashboard Chore: reintroduce gosec (grafana#17021) Gauge: tweaks to background color and height usage (grafana#17019) Feature: provide multildap server configuration (grafana#16914) (feat/explore): Support for new LogQL filtering syntax (grafana#16674) fix(explore): Prevent double querying for Prometheus and Loki (grafana#17004) Chore: No implict any fixes (grafana#17020) move log package to /infra (grafana#17023) Chore: Lowered implicit anys limit to 5386 Chore: Updated snapshot Select: Fixed isOpen issue Chore: Typescript no-implicit any fixes progress (grafana#17018) GraphPanel: show results for all SeriesData (grafana#16966) Fix: Wrap value of multi variable in array when coming from URL (grafana#16992) GettingStarted: add key and remove ng-class (grafana#17007) explore: add some extra time for angular query editors to update query (grafana#16955) Explore: Align Explore with Dashboards and Panels (grafana#16823) Explore: Fix empty result from datasource should render logs container (grafana#16999) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #15942
When multiple choice option is selected it is wrapped in array even if only one option is selected. When refreshed and taken from URL though it is set as single string instead. This wraps the value in array for those cases to normalize the behaviour.