Explore: Don't parse log levels if provided by field or label #17180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugohaggmark
approved these changes
May 21, 2019
marefr
added this to Under review
in Observability (deprecated, use Observability Squad)
via automation
Observability (deprecated, use Observability Squad)
automation
moved this from Under review
to Done
May 27, 2019
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 30, 2019
…-grafanaui * grafana/master: (92 commits) LDAP: remove unused function (grafana#17351) Enterprise: remove gofakeit dep (grafana#17344) Explore: Update time range before running queries (grafana#17349) Build(package.json): improve npm commands (grafana#17022) Chore: upgrade webpack analyser (grafana#17340) NewDataSourcePage: Add Grafana Cloud link (grafana#17324) CloudWatch: Avoid exception while accessing results (grafana#17283) Build: ignore absence of docker-compose (grafana#17331) Build(makefile): improve error handling (grafana#17281) adds auth example for the cli cherrypick task (grafana#17307) docs: remove my email from docs examples (grafana#17325) 16365 change clashing variable names (grafana#17140) Frontend/SeriesData: Fix for convert SeriesData to Table format (grafana#17314) Frontend/utils: Import has only from lodash (grafana#17311) Frontend/utils: Add missing type (grafana#17312) update v6.2-beta1 changelog with missing pr (grafana#17308) explore: don't parse log levels if provided by field or label (grafana#17180) HTTP Server: Serve Grafana with a custom URL path prefix (grafana#17048) update latest.json to latest stable version (grafana#17306) release: v6.2.1 changelog update (grafana#17303) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a field or a label named
levelis returned from datasource that is used as log level for the logs result instead of parsing the log level from the message.Which issue(s) this PR fixes:
Closes #17122
Special notes for your reviewer:
#17182 makes testing fields having a field name level or not at least.